Displaying #apache-syncope/2016-07-19.log:

Tue Jul 19 07:07:12 2016  tusharm:Joined the channel
Tue Jul 19 07:17:25 2016  _massi_:Joined the channel
Tue Jul 19 07:19:35 2016  sberyozkin:Joined the channel
Tue Jul 19 07:25:48 2016  ilgrosso:Joined the channel
Tue Jul 19 07:27:28 2016  fmartelli:Joined the channel
Tue Jul 19 07:27:40 2016  tusharm:Joined the channel
Tue Jul 19 08:03:25 2016  svizzero81:Joined the channel
Tue Jul 19 08:11:24 2016  ilgrosso:tusharm: can you take a look at https://github.com/tmess567/SYNCOPE-809/issues/9 (my very last comment)?
Tue Jul 19 09:04:05 2016  coheigea:Joined the channel
Tue Jul 19 09:32:55 2016  tusharm:Joined the channel
Tue Jul 19 09:37:15 2016  tusharm:Joined the channel
Tue Jul 19 09:38:30 2016  tusharm:ilgrosso: I have restructured the project and it now builds a p2 repo archive which I have tested to be working
Tue Jul 19 09:40:06 2016  tusharm:Now, starting work on integration with my syncope fork. Any guidelines or suggestions?
Tue Jul 19 09:45:55 2016  ilgrosso:tusharm: great news
Tue Jul 19 09:46:20 2016  ilgrosso:1. create your own SYNCOPE-809 branch, rebased on Syncope's master
Tue Jul 19 09:46:45 2016  ilgrosso:2. from root directory, please your code under ide/eclipse
Tue Jul 19 09:46:53 2016  ilgrosso:*put
Tue Jul 19 09:47:52 2016  ilgrosso:3. if you need to add dependencies, first place them (with version) under <dependencyManagement> in root pom, then add to your own module(s), without version
Tue Jul 19 09:47:59 2016  tusharm:Cool! Will do that and report
Tue Jul 19 09:48:05 2016  ilgrosso:same for plugins, under <pluginManagement>
Tue Jul 19 09:48:37 2016  ilgrosso:for the rest we will settle afterwards
Tue Jul 19 10:17:32 2016  tusharm:My only dependency is syncope-client-lib for which i am using ${project.version} for it's version
Tue Jul 19 10:17:40 2016  ilgrosso:perfect
Tue Jul 19 10:18:23 2016  tusharm:However, there are some project specific properties defined in the root of my project. Do I need to move them to the root pom?
Tue Jul 19 10:19:31 2016  tusharm:They are:
Tue Jul 19 10:19:33 2016  tusharm:<tycho-version>0.25.0</tycho-version> <maven.compiler.source>1.8</maven.compiler.source> <maven.compiler.target>1.8</maven.compiler.target> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
Tue Jul 19 10:20:11 2016  ilgrosso:Remove <maven.compiler.source>1.8</maven.compiler.source> <maven.compiler.target>1.8</maven.compiler.target> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
Tue Jul 19 10:20:42 2016  tusharm:ok
Tue Jul 19 10:20:43 2016  ilgrosso:and put <tycho-version>0.25.0</tycho-version in the root pom, with related dependencies in <dependencyManagement> with version
Tue Jul 19 10:20:58 2016  ilgrosso:always in the root pom
Tue Jul 19 10:21:12 2016  ilgrosso:then reference such dependencies in your poms but *without* version
Tue Jul 19 10:21:23 2016  ilgrosso:the goal is to control all versions from the root pom
Tue Jul 19 10:26:39 2016  tusharm:adding licenses to ensure rat checks are passed
Tue Jul 19 10:31:57 2016  ilgrosso:good
Tue Jul 19 10:32:08 2016  ilgrosso:please check with other files in the repo for the correct header text
Tue Jul 19 10:32:36 2016  ilgrosso:RAT is not good enough to distinguish between the generic AL 2.0 header and ASF header
Tue Jul 19 10:35:12 2016  tusharm:I will be using the ASF header right?
Tue Jul 19 10:36:39 2016  ilgrosso:right
Tue Jul 19 10:36:51 2016  ilgrosso:check with other files in the repo and you'll be fine
Tue Jul 19 10:37:12 2016  ilgrosso:.java with .java, .xml with .xml, .properties with .properties and so on
Tue Jul 19 10:42:27 2016  tusharm:Joined the channel
Tue Jul 19 11:30:47 2016  tusharm:For some reason, the checkstyle plugin is looking for the config file in "ide/eclipse/src/main/resources/org/apache/syncope/"
Tue Jul 19 11:31:08 2016  ilgrosso:you need to set the related property
Tue Jul 19 11:31:19 2016  ilgrosso: <rootpom.basedir>${basedir}/..</rootpom.basedir>
Tue Jul 19 11:31:33 2016  tusharm:oh, ok
Tue Jul 19 11:31:34 2016  ilgrosso:where the value will point back to the root pom
Tue Jul 19 11:31:37 2016  ilgrosso:directory
Tue Jul 19 11:31:46 2016  ilgrosso:(see other modules)
Tue Jul 19 11:32:02 2016  ilgrosso:possibly, make ide a submodule itself
Tue Jul 19 11:32:11 2016  ilgrosso:similarly to client/ or console/
Tue Jul 19 11:32:22 2016  ilgrosso:client/ or core/ or fit/ I was meaning
Tue Jul 19 11:33:32 2016  tusharm:ok, will do
Tue Jul 19 11:45:05 2016  svizzero81:Joined the channel
Tue Jul 19 11:53:41 2016  svizzero81:Joined the channel
Tue Jul 19 12:00:41 2016  tusharm:Joined the channel
Tue Jul 19 12:04:06 2016  fmartelli:Joined the channel
Tue Jul 19 12:41:27 2016  svizzero81:Joined the channel
Tue Jul 19 13:14:20 2016  fmartelli:Joined the channel
Tue Jul 19 14:06:22 2016  tusharm:Joined the channel
Tue Jul 19 14:14:46 2016  _massi_1:Joined the channel
Tue Jul 19 14:17:31 2016  _massi_:Joined the channel
Tue Jul 19 14:47:27 2016  fmartelli:Joined the channel
Tue Jul 19 15:22:31 2016  fmartelli:Joined the channel
Tue Jul 19 15:36:02 2016  tusharm:Left the channel
Tue Jul 19 18:01:32 2016  coheigea:Left the channel
Tue Jul 19 20:04:20 2016  svizzero81:Joined the channel
Tue Jul 19 22:19:44 2016  _massi_:Joined the channel

Comments