Displaying #apache-syncope/2017-06-22.log:

Thu Jun 22 01:06:36 2017  syncope-bot:Joined the channel
Thu Jun 22 01:10:47 2017  syncope-bot:Joined the channel
Thu Jun 22 01:15:01 2017  syncope-bot:Joined the channel
Thu Jun 22 01:18:35 2017  syncope-bot:Joined the channel
Thu Jun 22 01:24:25 2017  syncope-bot:Joined the channel
Thu Jun 22 01:31:35 2017  syncope-bot:Joined the channel
Thu Jun 22 01:36:47 2017  syncope-bot_:Joined the channel
Thu Jun 22 01:38:47 2017  syncope-bot:Joined the channel
Thu Jun 22 04:23:57 2017  ilgrosso:Joined the channel
Thu Jun 22 06:47:11 2017  andreapatricelli:Joined the channel
Thu Jun 22 06:56:26 2017  fmartelli:Joined the channel
Thu Jun 22 07:00:18 2017  ilgrosso:Joined the channel
Thu Jun 22 07:05:22 2017  fmartelli:Joined the channel
Thu Jun 22 07:49:36 2017  svizzero81:Joined the channel
Thu Jun 22 07:49:39 2017  fmartelli:Joined the channel
Thu Jun 22 08:27:04 2017  coheigea:Joined the channel
Thu Jun 22 09:18:22 2017  sberyozkin:Joined the channel
Thu Jun 22 09:25:22 2017  ilgrosso:Joined the channel
Thu Jun 22 10:26:46 2017  svizzero81:Joined the channel
Thu Jun 22 11:21:11 2017  fmartelli:Joined the channel
Thu Jun 22 11:26:11 2017  ilgrosso:Joined the channel
Thu Jun 22 12:03:53 2017  svizzero81:Joined the channel
Thu Jun 22 12:08:06 2017  ilgrosso:syncope-bot: force build syncope-master-docs
Thu Jun 22 12:08:07 2017  syncope-bot:build forced [ETA 2m40s]
Thu Jun 22 12:08:07 2017  syncope-bot:I'll give a shout when the build finishes
Thu Jun 22 12:08:12 2017  ilgrosso:syncope-bot: force build syncope-2_0_X-docs
Thu Jun 22 12:08:13 2017  syncope-bot:build forced [ETA 2m42s]
Thu Jun 22 12:08:13 2017  syncope-bot:I'll give a shout when the build finishes
Thu Jun 22 12:08:38 2017  ilgrosso:coheigea: my last two messages above trigegr update of published SNAPSHOT docs
Thu Jun 22 12:08:57 2017  ilgrosso:so that your commit above is published
Thu Jun 22 12:09:38 2017  ilgrosso:under https://ci.apache.org/projects/syncope/2_0_X/ and https://ci.apache.org/projects/syncope/master/
Thu Jun 22 12:09:55 2017  coheigea:ah ok cool
Thu Jun 22 12:09:56 2017  ilgrosso:2_0_X is also copied under https://ci.apache.org/projects/syncope/getting-started.html
Thu Jun 22 12:10:05 2017  ilgrosso:and https://ci.apache.org/projects/syncope/reference-guide.html
Thu Jun 22 12:10:27 2017  ilgrosso:(which are linked from http://syncope.apache.org/docs/ under the Snaphost column
Thu Jun 22 12:10:35 2017  ilgrosso:*Snapshot
Thu Jun 22 12:11:31 2017  ilgrosso:syncope-bot will notify here once built
Thu Jun 22 12:12:39 2017  syncope-bot:Hey! build syncope-master-docs #395 is complete: Success [build successful]
Thu Jun 22 12:12:39 2017  syncope-bot:Build details are at https://ci.apache.org/builders/syncope-master-docs/builds/395
Thu Jun 22 12:12:42 2017  syncope-bot:Hey! build syncope-2_0_X-docs #105 is complete: Success [build successful]
Thu Jun 22 12:12:42 2017  syncope-bot:Build details are at https://ci.apache.org/builders/syncope-2_0_X-docs/builds/105
Thu Jun 22 12:20:23 2017  coheigea:syncope-bot: force build syncope-master-docs
Thu Jun 22 12:20:24 2017  syncope-bot:build forced [ETA 3m36s]
Thu Jun 22 12:20:24 2017  syncope-bot:I'll give a shout when the build finishes
Thu Jun 22 12:20:36 2017  coheigea:syncope-bot: force build syncope-2_0_X-docs
Thu Jun 22 12:20:41 2017  syncope-bot:The build has been queued, I'll give a shout when it starts
Thu Jun 22 12:21:41 2017  syncope-bot:build forced [ETA 3m07s]
Thu Jun 22 12:21:41 2017  syncope-bot:I'll give a shout when the build finishes
Thu Jun 22 12:23:09 2017  syncope-bot:Hey! build syncope-master-docs #396 is complete: Success [build successful]
Thu Jun 22 12:23:09 2017  syncope-bot:Build details are at https://ci.apache.org/builders/syncope-master-docs/builds/396
Thu Jun 22 12:24:20 2017  syncope-bot:Hey! build syncope-2_0_X-docs #107 is complete: Success [build successful]
Thu Jun 22 12:24:20 2017  syncope-bot:Build details are at https://ci.apache.org/builders/syncope-2_0_X-docs/builds/107
Thu Jun 22 12:49:26 2017  fmartelli:Joined the channel
Thu Jun 22 15:07:28 2017  sberyozkin:Joined the channel
Thu Jun 22 15:07:48 2017  sberyozkin:Joined the channel
Thu Jun 22 15:17:13 2017  sberyozkin:Joined the channel
Thu Jun 22 16:16:32 2017  ilgrosso:Joined the channel
Thu Jun 22 16:16:53 2017  ilgrosso:coheigea: ping
Thu Jun 22 16:17:00 2017  coheigea:ilgrosso: pong
Thu Jun 22 16:17:04 2017  ilgrosso:I've seen your recent commits and got two questions
Thu Jun 22 16:17:23 2017  coheigea:sure
Thu Jun 22 16:17:35 2017  ilgrosso:1. would it be possible to remove credentialChecker.checkIsDefaultJWSKeyInUse(); from JWTAuthenticationFilter?
Thu Jun 22 16:17:55 2017  ilgrosso:I see it in the AccessTokenDataBinderImpl, e.g. when the token is created or refreshed - ok
Thu Jun 22 16:18:05 2017  ilgrosso:but why perform the check at every further REST call?
Thu Jun 22 16:18:32 2017  coheigea:why not perform the check?
Thu Jun 22 16:18:46 2017  ilgrosso:because it consumes time
Thu Jun 22 16:19:02 2017  ilgrosso:especially when you do that for each and every REST call
Thu Jun 22 16:19:13 2017  coheigea:It's just a boolean check though, assuming the key is changed?
Thu Jun 22 16:20:18 2017  ilgrosso:hum... so the purpose is to fill the log file with plenty of WARN messages in order to discourage use of default JWS?
Thu Jun 22 16:22:23 2017  coheigea:well not really. I don't mind removing it from the filter if you'd prefer that.
Thu Jun 22 16:22:58 2017  ilgrosso:no no, I am just asking
Thu Jun 22 16:23:32 2017  ilgrosso:I was wondering if it might be honerous to perform the check there, since that code is involved with all REST calls
Thu Jun 22 16:23:48 2017  ilgrosso:but it's just a boolean check after all, as you say
Thu Jun 22 16:24:03 2017  ilgrosso:question 2 is about checkIsDefaultAdminPasswordInUse - that method should be placed around https://github.com/apache/syncope/blob/master/core/spring/src/main/java/org/apache/syncope/core/spring/security/UsernamePasswordAuthenticationProvider.java#L102 right?
Thu Jun 22 16:24:14 2017  coheigea:yeah I haven't gotten around to wiring that in yet :-)
Thu Jun 22 16:24:49 2017  ilgrosso:ah ok :-)
Thu Jun 22 16:25:02 2017  ilgrosso:well I believe it should be placed there, it's the only place where admin's password is checked
Thu Jun 22 16:25:19 2017  coheigea:ok will take a look tomorrow
Thu Jun 22 16:26:52 2017  ilgrosso:thx
Thu Jun 22 16:56:31 2017  coheigea:Left the channel
Thu Jun 22 21:48:36 2017  ilgrosso:Joined the channel

Comments