Displaying #apache-syncope/2017-08-31.log:

Thu Aug 31 04:19:35 2017  lazybear:Joined the channel
Thu Aug 31 04:53:27 2017  jbonofre:Joined the channel
Thu Aug 31 06:11:51 2017  ilgrosso:Joined the channel
Thu Aug 31 06:12:14 2017  fmartelli:Joined the channel
Thu Aug 31 06:13:36 2017  ilgrosso:Joined the channel
Thu Aug 31 06:25:04 2017  ilgrosso:syncope-bot: force build syncope-2_0_X-docs
Thu Aug 31 06:25:05 2017  syncope-bot:build forced [ETA 2m54s]
Thu Aug 31 06:25:05 2017  syncope-bot:I'll give a shout when the build finishes
Thu Aug 31 06:27:51 2017  syncope-bot:Hey! build syncope-2_0_X-docs #193 is complete: Success [build successful]
Thu Aug 31 06:27:51 2017  syncope-bot:Build details are at https://ci.apache.org/builders/syncope-2_0_X-docs/builds/193
Thu Aug 31 06:40:27 2017  ilgrosso:syncope-bot: force build syncope-2_0_X-docs
Thu Aug 31 06:40:28 2017  syncope-bot:build forced [ETA 2m50s]
Thu Aug 31 06:40:28 2017  syncope-bot:I'll give a shout when the build finishes
Thu Aug 31 06:40:33 2017  ilgrosso:syncope-bot: force build syncope-master-docs
Thu Aug 31 06:40:34 2017  syncope-bot:build forced [ETA 2m51s]
Thu Aug 31 06:40:34 2017  syncope-bot:I'll give a shout when the build finishes
Thu Aug 31 06:44:28 2017  syncope-bot:Hey! build syncope-2_0_X-docs #194 is complete: Success [build successful]
Thu Aug 31 06:44:28 2017  syncope-bot:Build details are at https://ci.apache.org/builders/syncope-2_0_X-docs/builds/194
Thu Aug 31 06:44:59 2017  syncope-bot:Hey! build syncope-master-docs #483 is complete: Success [build successful]
Thu Aug 31 06:45:00 2017  syncope-bot:Build details are at https://ci.apache.org/builders/syncope-master-docs/builds/483
Thu Aug 31 06:48:43 2017  andreapatricelli:Joined the channel
Thu Aug 31 07:17:32 2017  fmartelli:Joined the channel
Thu Aug 31 07:17:37 2017  skylark17:Joined the channel
Thu Aug 31 08:27:47 2017  coheigea:Joined the channel
Thu Aug 31 09:01:35 2017  sberyozkin:Joined the channel
Thu Aug 31 09:10:05 2017  fmartelli:Joined the channel
Thu Aug 31 10:03:52 2017  fmartelli:Joined the channel
Thu Aug 31 11:42:08 2017  jbonofre:Joined the channel
Thu Aug 31 12:01:16 2017  jbonofre:Joined the channel
Thu Aug 31 13:24:13 2017  fmartelli:Joined the channel
Thu Aug 31 13:31:41 2017  fmartelli:Joined the channel
Thu Aug 31 14:30:41 2017  coheigea:ilgrosso: ping
Thu Aug 31 14:31:29 2017  ilgrosso:coheigea: pong
Thu Aug 31 14:32:34 2017  coheigea:ilgrosso: There are a few places in SAML2SPLogic where I think wrong variables are referenced. e.g. on line 478 an IllegalArgumentException is thrown if nameID == null, however this is flagged as dead code in eclipse. I think instead it should check if keyValue == null here.
Thu Aug 31 14:33:18 2017  coheigea:Then below it "nameID.getValue()" is referenced a good few times, not sure what the logic should be here.
Thu Aug 31 14:33:41 2017  ilgrosso:I don't see problems there, nor sees Netbeans :-)
Thu Aug 31 14:34:29 2017  coheigea:On line +427 we have: if (StringUtils.isNotBlank(nameID.getValue())
Thu Aug 31 14:34:36 2017  coheigea:so if nameID is null we already know about it at that point
Thu Aug 31 14:34:40 2017  ilgrosso:I agree that nameID.getValue() should be replaced with nameIDValue
Thu Aug 31 14:34:58 2017  ilgrosso:ah I see
Thu Aug 31 14:35:16 2017  ilgrosso:that's probably because of several refactoring
Thu Aug 31 14:35:39 2017  ilgrosso:uhm+
Thu Aug 31 14:35:44 2017  ilgrosso:it's a bit more involved
Thu Aug 31 14:35:51 2017  ilgrosso:it's if (StringUtils.isNotBlank(nameID.getValue())
Thu Aug 31 14:35:51 2017  ilgrosso: && idp.getConnObjectKeyItem().getExtAttrName().equals("NameID")) {
Thu Aug 31 14:36:22 2017  ilgrosso:coheigea: do you already have a refactoring proposal?
Thu Aug 31 14:36:35 2017  coheigea:ilgrosso: No, I just thought I'd point it out :-)
Thu Aug 31 14:37:01 2017  ilgrosso:let me se...
Thu Aug 31 14:39:18 2017  ilgrosso:coheigea: would this be enough? https://gist.github.com/ilgrosso/c6ec5b9086dfbe6a5a8435ad6412ad1a
Thu Aug 31 14:41:29 2017  coheigea:ilgrosso: Looks good! Just let me finish merging to 2_0_X before you merge back there...
Thu Aug 31 14:41:39 2017  ilgrosso:coheigea: fine
Thu Aug 31 14:44:13 2017  ilgrosso:coheigea: sorry for the noise, I've just realized that the LOG statements were also incorrect
Thu Aug 31 14:44:14 2017  ilgrosso:see https://gist.github.com/ilgrosso/c6ec5b9086dfbe6a5a8435ad6412ad1a
Thu Aug 31 14:44:17 2017  ilgrosso:(udpated)
Thu Aug 31 14:45:51 2017  coheigea:ilgrosso: +1
Thu Aug 31 14:46:47 2017  ilgrosso:coheigea: thx
Thu Aug 31 14:49:27 2017  ilgrosso:coheigea: SAML2IdPWizardBuilder does not build in 2_0_X
Thu Aug 31 14:49:43 2017  coheigea:ok one sec, currently building the branch locally
Thu Aug 31 14:49:50 2017  ilgrosso:because of the Java 7 compatibility, you need to set
Thu Aug 31 14:49:51 2017  ilgrosso: AjaxCheckBoxPanel supportUnsolicited = new AjaxCheckBoxPanel(
Thu Aug 31 14:49:51 2017  ilgrosso: "field", "supportUnsolicited", new PropertyModel<Boolean>(idpTO, "supportUnsolicited"), false);
Thu Aug 31 14:50:07 2017  ilgrosso:e.g. PropertyModel<Boolean>, not PropertyModel<> (which works with Java 8)
Thu Aug 31 14:50:44 2017  coheigea:yep thanks
Thu Aug 31 15:48:19 2017  jbonofre:Joined the channel
Thu Aug 31 16:49:49 2017  coheigea:Left the channel
Thu Aug 31 17:39:27 2017  coheigea:Joined the channel
Thu Aug 31 17:40:42 2017  coheigea:Left the channel
Thu Aug 31 20:55:02 2017  jbonofre:Joined the channel

Comments