Displaying #apache-syncope/2017-09-06.log:

Wed Sep 6 06:09:21 2017  ilgrosso:Joined the channel
Wed Sep 6 06:46:08 2017  fmartelli:Joined the channel
Wed Sep 6 06:46:16 2017  andreapatricelli:Joined the channel
Wed Sep 6 07:08:39 2017  fmartelli:Joined the channel
Wed Sep 6 07:14:04 2017  skylark17:Joined the channel
Wed Sep 6 08:14:18 2017  skylark17:Joined the channel
Wed Sep 6 08:14:58 2017  andreapatricelli:Joined the channel
Wed Sep 6 08:20:46 2017  coheigea:Joined the channel
Wed Sep 6 08:36:23 2017  sberyozkin:Joined the channel
Wed Sep 6 10:15:41 2017  ilgrosso:coheigea: I hope the third is the good one
Wed Sep 6 10:18:00 2017  coheigea:ilgrosso: hehe let's hope so
Wed Sep 6 10:28:52 2017  fmartelli:Joined the channel
Wed Sep 6 10:31:40 2017  coheigea:ilgrosso: When I checkout the syncope-2.0.5 tag, the last commit I see with git log is from Monday? I don't see the recent merges to 2_0_X on it
Wed Sep 6 10:32:15 2017  ilgrosso:coheigea: I see that
Wed Sep 6 10:32:16 2017  ilgrosso:https://github.com/apache/syncope/commits/syncope-2.0.5
Wed Sep 6 10:32:26 2017  ilgrosso:maybe you'll need to do some git pull --tags on your local repo
Wed Sep 6 10:33:17 2017  coheigea:ah yeah that's it, thanks!
Wed Sep 6 10:33:32 2017  ilgrosso:np
Wed Sep 6 11:29:00 2017  coheigea:ilgrosso: There is something odd about the source zip. It has a load of empty directories in it. https://dist.apache.org/repos/dist/dev/syncope/2.0.5/syncope-2.0.5-source-release.zip
Wed Sep 6 11:29:46 2017  ilgrosso:coheigea: what exactly?
Wed Sep 6 11:30:02 2017  ilgrosso:I can unzip and build works out fine
Wed Sep 6 11:30:19 2017  coheigea:ilgrosso: Unzip it and do "find . -type d -empty", e.g. ./fit/console-reference/src/main/java
Wed Sep 6 11:30:19 2017  coheigea:./fit/build-tools/src/test/java
Wed Sep 6 11:30:19 2017  coheigea:./core/persistence-api/src/main/resources
Wed Sep 6 11:31:13 2017  ilgrosso:I see, but I do not understand why this is an issue
Wed Sep 6 11:31:31 2017  ilgrosso:empty directories are simply ignored by GIT, hence you won't find them there
Wed Sep 6 11:31:57 2017  ilgrosso:but if I have empty dirs in my local clone, then the created sources ZIP will have those
Wed Sep 6 11:32:18 2017  coheigea:ilgrosso: ah ok that explains it.
Wed Sep 6 11:32:51 2017  ilgrosso:if you can enlist all of them, I'll remove from my local clone, to avoid that in 2.0.6
Wed Sep 6 11:33:16 2017  coheigea:yep ok will send you the list
Wed Sep 6 11:33:32 2017  coheigea:or you could do something like: find . -type d -empty | xargs rm -r
Wed Sep 6 11:35:17 2017  coheigea:actually my reason for asking is that the core-ref tests won't start for me on the source zip, but work fine on the git tag
Wed Sep 6 11:36:12 2017  coheigea:Hmm I get the same buildNumber error in the logs
Wed Sep 6 11:36:36 2017  ilgrosso:coheigea: are you running from the source ZIP?
Wed Sep 6 11:36:54 2017  coheigea:ilgrosso: Yeah. Let me try with a clean maven repo, as I built the tag first.
Wed Sep 6 11:37:02 2017  ilgrosso:if so, you'll need to pass the buildNumber argument, as specified in the release process
Wed Sep 6 11:37:27 2017  ilgrosso:the point is that if you are not building from a GIT clone, the build-maven-plugin will not work
Wed Sep 6 11:37:39 2017  ilgrosso:hence buildNumber won't be populated
Wed Sep 6 11:38:05 2017  coheigea:ah right ok. Where is this documented?
Wed Sep 6 11:38:31 2017  ilgrosso:http://syncope.apache.org/2.0.5/release-process.html#Prepare_the_release
Wed Sep 6 11:38:39 2017  ilgrosso:(it's under /2.0.5 because is not published yet)
Wed Sep 6 11:38:53 2017  ilgrosso:it's the -DbuildNumber=syncope-$VERSION
Wed Sep 6 11:39:01 2017  ilgrosso:e.g. -DbuildNumber=syncope-2.0.5 in this case
Wed Sep 6 11:39:08 2017  ilgrosso:but you can actually put whatever
Wed Sep 6 11:39:22 2017  ilgrosso:(buildNumber is not relevant for releases, only for SNAPSHOTs)
Wed Sep 6 11:40:31 2017  coheigea:ok thanks. Perhaps we need to add a README to the source so that someone who grabs the source will know how to build it properly?
Wed Sep 6 11:41:03 2017  ilgrosso:makes sense.. or we should change the way how the buildNumber is passed from files to Java, to avoid Spring errors
Wed Sep 6 11:41:29 2017  ilgrosso:could we pospone this to 2.0.6 in your opinion=
Wed Sep 6 11:41:31 2017  ilgrosso:?
Wed Sep 6 11:42:23 2017  coheigea:Yes, it's not urgent
Wed Sep 6 11:43:00 2017  ilgrosso:ok
Wed Sep 6 12:52:42 2017  fmartelli:Joined the channel
Wed Sep 6 12:58:19 2017  skylark18:Joined the channel
Wed Sep 6 12:58:37 2017  andreapatricell1:Joined the channel
Wed Sep 6 12:58:46 2017  fmartelli1:Joined the channel
Wed Sep 6 13:00:30 2017  ilgrosso:Joined the channel
Wed Sep 6 15:26:20 2017  skylark17:Joined the channel
Wed Sep 6 15:29:13 2017  skylark18:Joined the channel
Wed Sep 6 15:29:50 2017  ilgrosso:sberyozkin: nice to see your vote :-)
Wed Sep 6 16:47:43 2017  coheigea:Left the channel

Comments