Displaying #maven-dev/2017-02-09.log:

Thu Feb 9 02:58:57 2017  ASFBot:Joined the channel
Thu Feb 9 09:53:25 2017  rfscholte:Joined the channel
Thu Feb 9 09:54:11 2017  rfscholte:stephenc: Hi Stephen, how should I read this: https://builds.apache.org/job/maven-3.x-jenkinsfile/job/MNG-6109/1/ success or failure?
Thu Feb 9 09:55:01 2017  stephenc:@rfscholte looks like failure... I'll double check the logs though
Thu Feb 9 09:56:14 2017  stephenc:@rfscholte: https://builds.apache.org/job/maven-3.x-jenkinsfile/job/MNG-6109/1/execution/node/62/log/
Thu Feb 9 09:56:23 2017  stephenc:did you push a matching Integration test branch?
Thu Feb 9 09:56:59 2017  rfscholte:no, it's only a unittest, no need for an IT
Thu Feb 9 09:57:21 2017  rfscholte:ah, I think I see the issue
Thu Feb 9 09:57:22 2017  stephenc:@rfscholte then why https://github.com/apache/maven/blob/MNG-6109/Jenkinsfile#L22
Thu Feb 9 09:58:05 2017  rfscholte:that should have stayed master
Thu Feb 9 09:58:12 2017  stephenc:@rfscholte you should have like https://github.com/apache/maven/blob/master/Jenkinsfile#L22 *unless* you want to have a coordinated change to integration tests
Thu Feb 9 09:58:25 2017  stephenc:@rfscholte this will get easier once infra updates
Thu Feb 9 09:59:30 2017  stephenc:@rfscholte https://github.com/jenkinsci/workflow-multibranch-plugin/blob/master/src/main/java/org/jenkinsci/plugins/workflow/multibranch/ResolveScmStep.java#L71
Thu Feb 9 09:59:45 2017  stephenc:with that we will be able to do something like
Thu Feb 9 10:01:10 2017  rfscholte:nice
Thu Feb 9 10:01:22 2017  stephenc:def tests = resolveScm(source: git(url:'https://git-wip-us.apache.org/repos/asf/maven-integration-testing.git'), targets:[BRANCH_NAME,'master']);
Thu Feb 9 10:01:28 2017  stephenc:and then
Thu Feb 9 10:01:32 2017  stephenc:checkout tests
Thu Feb 9 10:02:04 2017  stephenc:which will basically auto-wire the integration tests to a matching branch name if it exists and fall back to master if it doesn't
Thu Feb 9 10:02:27 2017  rfscholte:makes sense
Thu Feb 9 10:02:46 2017  stephenc:and better yet, it will check out *the same revision* of the tests on all nodes
Thu Feb 9 10:03:07 2017  rfscholte:cool
Thu Feb 9 10:03:13 2017  stephenc:currently you could have different revisions if somebody adds a commit to integration tests while waiting for a node
Thu Feb 9 10:27:36 2017  olamy:Joined the channel
Thu Feb 9 11:35:36 2017  rfscholte:stephenc: yeah, now it's blue (or green...)
Thu Feb 9 11:35:51 2017  stephenc:cool!
Thu Feb 9 20:08:19 2017  tibor_:Joined the channel

Comments