Displaying #maven-dev/2017-02-26.log:

Sun Feb 26 04:56:09 2017  theRealGent:Joined the channel
Sun Feb 26 04:58:10 2017  theRealGent:Joined the channel
Sun Feb 26 05:27:39 2017  aheritier_:Joined the channel
Sun Feb 26 10:22:19 2017  hboutemy:Joined the channel
Sun Feb 26 10:45:18 2017  rfscholte:Joined the channel
Sun Feb 26 11:09:36 2017  Michael-O:Joined the channel
Sun Feb 26 13:57:47 2017  tibor_:Joined the channel
Sun Feb 26 15:26:53 2017  Michael-O:Joined the channel
Sun Feb 26 15:27:22 2017  Michael-O:tibor_: is there anything you nedd furthter tested or do you have enough information?
Sun Feb 26 15:27:33 2017  Michael-O:Did you succeed in installtion FreeBSD on your machine?
Sun Feb 26 15:28:38 2017  tibor_:I was reworking our IT. All TestNG tests and avoided the system properties which are duplicates. It is good for code clarity and maintenance.
Sun Feb 26 15:29:17 2017  tibor_:@Michael-O: I think we sould use std/err for communication. WDYT?
Sun Feb 26 15:29:40 2017  tibor_:I was very tired this week.
Sun Feb 26 15:29:45 2017  Michael-O:We can try because this is cheap do to so, isn't it?
Sun Feb 26 15:29:54 2017  Michael-O:Me too. Had a hard testing and personal week.
Sun Feb 26 15:32:03 2017  tibor_:Yes, it is easy. We can have a look in last few commits of mine in the latest branch experimental-2.19.2 and we can see 3 locations where I added .close(). These are the location where err should be used. Now the ForkStarter on the bottom of the class ThreadedStreamConsumer is std/out and thus two method params sitched.
Sun Feb 26 15:32:13 2017  tibor_:switched
Sun Feb 26 15:32:55 2017  tibor_:I was testing and reworking 17 ITs whole day.
Sun Feb 26 15:34:13 2017  Michael-O:It is extremely exhausting. Took me al lot of energy running vairous tests, collecting, etc.
Sun Feb 26 15:49:53 2017  tibor_:Michael-O: I know. I was tired too. I promis I will install FreeBSD. Chriastain pushed PR in github collecting unrelated things. Some ideas are god and some need to discuss..
Sun Feb 26 15:50:10 2017  tibor_:Christian, my typos
Sun Feb 26 15:55:27 2017  tibor_:Michael-O: many of us see that JVM did not end up correctly. So we inherently thought the exit was the problem. Mistakenly. The initial problem is when then JVM starts. The Maven process receieved signal from forked one "give me a class to test", and plugin answered but no data could be written to forked jvm because Process.getOutputStream() was never reached.
Sun Feb 26 15:56:07 2017  Michael-O:So the VM starved and exited?
Sun Feb 26 15:56:20 2017  tibor_:Therefore after forked JVM existed, all the data like NOOP, and RUN_CLASS was send, but all was too late.
Sun Feb 26 15:56:42 2017  tibor_:maybe std/err will solve this.
Sun Feb 26 15:56:51 2017  Michael-O:We need to ACKs, one after start and one before exit?
Sun Feb 26 15:56:57 2017  tibor_:It looks like deadlock.
Sun Feb 26 15:57:04 2017  Michael-O:ouch
Sun Feb 26 15:57:21 2017  tibor_:Maybe no reason to test.
Sun Feb 26 15:59:17 2017  tibor_:If you open some logs, I can send you sample, and if you open Surefire code you will see wha I mean. But we go as deep as many logs we have. And in my experiences sometimes I do not see obvious things, and funny is that anybody having a look as well tell me where the bug is. Sometimes the devs are blind to see error.
Sun Feb 26 16:00:29 2017  Michael-O:Reading your email.
Sun Feb 26 16:00:35 2017  tibor_:ok
Sun Feb 26 19:17:47 2017  stephenc:Michael-O I am running surefire on OS-X now
Sun Feb 26 19:18:07 2017  Michael-O:stephenc: looking forward to
Sun Feb 26 19:31:04 2017  stephenc:Michael-O it's ef8e9e395db652436ed9dcf22818c8e04768ad58 on the SUREFIRE_SYSPROP_DUPLICATES branch, yes?
Sun Feb 26 19:31:48 2017  stephenc:And I'm running with Maven 3.5.0-alpha-1 and Oracle Java 1.8.0_121
Sun Feb 26 19:39:54 2017  Michael-O:correct
Sun Feb 26 19:42:55 2017  tibor_:Joined the channel
Sun Feb 26 19:43:27 2017  tibor_:Michael-O: I have problem to convert two files to unix. do2unix in Fedora does not change them.
Sun Feb 26 19:45:09 2017  tibor_:It is the files in PR.
Sun Feb 26 19:45:36 2017  tibor_:It's so simple dos2unix Surefire...java, always worked.
Sun Feb 26 19:48:02 2017  tibor_:Michael-O: can you help?
Sun Feb 26 19:48:11 2017  Michael-O:give me 5 min
Sun Feb 26 20:02:00 2017  stephenc:Results :
Sun Feb 26 20:02:00 2017  stephenc:Tests run: 714, Failures: 0, Errors: 0, Skipped: 133
Sun Feb 26 20:02:00 2017  stephenc:[INFO]
Sun Feb 26 20:02:41 2017  stephenc:[INFO] ------------------------------------------------------------------------
Sun Feb 26 20:02:44 2017  stephenc:[INFO] BUILD SUCCESS
Sun Feb 26 20:02:47 2017  stephenc:[INFO] ------------------------------------------------------------------------
Sun Feb 26 20:02:50 2017  stephenc:[INFO] Total time: 43:21 min
Sun Feb 26 20:02:52 2017  stephenc:[INFO] Finished at: 2017-02-26T19:59:59Z
Sun Feb 26 20:02:54 2017  stephenc:@tibor / @Michael-O tests pass on OS-X
Sun Feb 26 20:02:57 2017  stephenc:[INFO] Final Memory: 54M/363M
Sun Feb 26 20:03:00 2017  stephenc:[INFO] ------------------------------------------------------------------------
Sun Feb 26 20:07:13 2017  tibor_:cool
Sun Feb 26 20:07:49 2017  tibor_:Is it Mac? Not FreeBSD?
Sun Feb 26 20:08:25 2017  Michael-O:tibor_: dos2unix does not perform any inline changes
Sun Feb 26 20:08:29 2017  tibor_:SO I used fromdos, and dos2unix but nothing works.
Sun Feb 26 20:08:32 2017  Michael-O:you have to do this with a temp file
Sun Feb 26 20:08:49 2017  Michael-O:alternatively, you use "sed -i" to perform chagnes
Sun Feb 26 20:09:53 2017  tibor_:Does it mean that it is matter of directory where the file is located?
Sun Feb 26 20:10:31 2017  Michael-O:http://stackoverflow.com/questions/800030/remove-carriage-return-in-unix/800644#800644
Sun Feb 26 20:10:47 2017  Michael-O:No, dos2unix never changes the file, you have to
Sun Feb 26 20:23:38 2017  Michael-O:tibor_: did it work? Piping and replacing?
Sun Feb 26 20:24:08 2017  tibor_:no it does not work, tr either
Sun Feb 26 20:24:24 2017  tibor_:I will try to replace with Java app.
Sun Feb 26 20:26:53 2017  Michael-O:what does "od -ax" say after conversion?
Sun Feb 26 20:26:57 2017  Michael-O:this is really weird
Sun Feb 26 20:38:29 2017  stephenc:tibor_: it's a pass on Mac
Sun Feb 26 20:41:30 2017  tibor_:I have it
Sun Feb 26 20:41:34 2017  tibor_:} cr } cr
Sun Feb 26 20:41:37 2017  tibor_:now
Sun Feb 26 20:41:40 2017  tibor_:} nl } nl
Sun Feb 26 20:41:56 2017  tibor_:going to commit
Sun Feb 26 20:48:42 2017  tibor_:https://github.com/apache/maven-surefire/commit/332b19fa287708906a3e85e7935855039329cf60
Sun Feb 26 20:48:49 2017  tibor_:Now the commit looks god.
Sun Feb 26 20:48:52 2017  tibor_:good
Sun Feb 26 20:49:31 2017  tibor_:The next step would be std/err.
Sun Feb 26 20:50:24 2017  tibor_:I will create a new branch from master.
Sun Feb 26 20:53:58 2017  Michael-O:checking commit
Sun Feb 26 20:55:25 2017  Michael-O:Looks good now
Sun Feb 26 20:55:47 2017  Michael-O:Create issue, amend commit message and merge into master
Sun Feb 26 21:03:13 2017  tibor_:https://issues.apache.org/jira/browse/SUREFIRE-1338
Sun Feb 26 21:04:45 2017  tibor_:done
Sun Feb 26 21:11:03 2017  Michael-O:Issue looks good to me
Sun Feb 26 21:12:09 2017  Michael-O:Commit message of 332b19fa287708906a3e85e7935855039329cf60 does not look good
Sun Feb 26 21:12:11 2017  Michael-O:it is not master now
Sun Feb 26 21:12:16 2017  Michael-O:no association with issue
Sun Feb 26 21:12:30 2017  tibor_:you mean the message?
Sun Feb 26 21:12:33 2017  Michael-O:Yes
Sun Feb 26 21:12:41 2017  tibor_:can it be changed?
Sun Feb 26 21:13:48 2017  tibor_:The message was originally in the branch.
Sun Feb 26 21:14:28 2017  tibor_:Should I git amend, and force push?
Sun Feb 26 21:18:47 2017  Michael-O:I likely won't be able to force push to master
Sun Feb 26 21:18:57 2017  Michael-O:only with in infra ticket
Sun Feb 26 21:19:35 2017  Michael-O:all we could do is the same approach with Maven, copy master branch, reset, bump to 2.21, cleanup commits, merge into master, release
Sun Feb 26 21:19:44 2017  tibor_:no
Sun Feb 26 21:20:15 2017  tibor_:if it is important, i can git force push
Sun Feb 26 21:20:32 2017  tibor_:should i?
Sun Feb 26 21:21:10 2017  Michael-O:Not without devs consent
Sun Feb 26 21:21:51 2017  tibor_:In Jira is commit.
Sun Feb 26 21:21:52 2017  Michael-O:on Sufefire master happened the same as on MAven master. A lof of commit, revert, commit, revert. It makes reading log very hard.
Sun Feb 26 21:22:35 2017  tibor_:Next time I will remember to rewrite comment in branch.
Sun Feb 26 21:24:41 2017  tibor_:How long is it usually to install FreeBSD?
Sun Feb 26 21:25:29 2017  tibor_:Did somebody test with OpenBSD? I guess Christian, or/
Sun Feb 26 21:56:38 2017  Michael-O:less than an hour
Sun Feb 26 21:56:48 2017  Michael-O:after install, it will be fully usable
Sun Feb 26 21:57:09 2017  Michael-O:you will need some ports like bash, Java, Git. That's it.

Comments