Displaying #maven-dev/2017-03-10.log:

Fri Mar 10 08:31:54 2017  olamy:Joined the channel
Fri Mar 10 08:48:26 2017  Michael-O:Joined the channel
Fri Mar 10 09:27:17 2017  tibor_:Joined the channel
Fri Mar 10 09:43:50 2017  rfscholte:Joined the channel
Fri Mar 10 13:47:52 2017  jieryn:Joined the channel
Fri Mar 10 13:47:52 2017  jieryn:Joined the channel
Fri Mar 10 14:34:14 2017  Michael-O:tibor_, I have a quick update for you
Fri Mar 10 15:47:48 2017  tibor_:Michael-O: I am back in IRC now.
Fri Mar 10 15:58:46 2017  Michael-O:I am doing futher tests, give me 30 min or so
Fri Mar 10 18:44:45 2017  Michael-O:Joined the channel
Fri Mar 10 19:32:23 2017  tibor_:Joined the channel
Fri Mar 10 19:40:50 2017  tibor_:Michael-O: Hi Michael. What you wanted to tell me?
Fri Mar 10 21:40:43 2017  Michael-O:Joined the channel
Fri Mar 10 21:41:37 2017  Michael-O:tibor_, tested your change on Fedora
Fri Mar 10 21:41:41 2017  Michael-O:works good now
Fri Mar 10 21:42:10 2017  tibor_:which branch
Fri Mar 10 21:42:13 2017  Michael-O:I also started to remove your changes file by file, no negative effects on the tests
Fri Mar 10 21:42:17 2017  Michael-O:2.19.2-experimental
Fri Mar 10 21:42:34 2017  tibor_:ok
Fri Mar 10 21:42:55 2017  Michael-O:can you remove all sleeps from the branch
Fri Mar 10 21:43:00 2017  Michael-O:there is no positive effect
Fri Mar 10 21:49:59 2017  tibor_:done
Fri Mar 10 21:55:26 2017  Michael-O:let me pull and test
Fri Mar 10 22:26:19 2017  Michael-O:tested, no negative effects
Fri Mar 10 22:47:16 2017  Michael-O:the remaining changes like flush and closes did not yield to any positive change
Fri Mar 10 23:10:47 2017  Michael-O:tibor_, have you tested on Ubuntu?
Fri Mar 10 23:11:58 2017  tibor_:what flush and close you mean?
Fri Mar 10 23:13:15 2017  Michael-O:those you added in the experimental branch
Fri Mar 10 23:13:46 2017  tibor_:you mean this we yesterday uncommented? flushReceiver = new OutputStreamFlushReceiver( process.getOutputStream() );
Fri Mar 10 23:14:01 2017  tibor_:and close what close?
Fri Mar 10 23:16:34 2017  Michael-O:no, not the flushReceiver, the rest. explicit flushes and close on the JAR entries
Fri Mar 10 23:17:12 2017  Michael-O:have a look at the branch michaelo/2.19.2-experimental
Fri Mar 10 23:17:24 2017  Michael-O:check out the tip, you'll see what I have removed for testing
Fri Mar 10 23:17:34 2017  tibor_:No, did not have time to use the branch on Ubuntu. The Jenkins build lost access to Nexus in the morning. SO I was fixing this and them made Java big fixing my collagues were waiting for.
Fri Mar 10 23:20:38 2017  Michael-O:No issue
Fri Mar 10 23:25:41 2017  tibor_:Are you facing any necessary changes I should make in regular Surefire?
Fri Mar 10 23:31:41 2017  Michael-O:None actually, you can of course merge the explicit flushes and JAR close to make the code more robust
Fri Mar 10 23:31:53 2017  Michael-O:We also wanted to disable PING to see what happens
Fri Mar 10 23:49:28 2017  tibor_:ping is disabled
Fri Mar 10 23:58:54 2017  Michael-O:ok, let me check

Comments