Displaying #maven-dev/2017-05-03.log:

Wed May 3 00:01:10 2017  Michael-O:Joined the channel
Wed May 3 07:16:22 2017  olamy:Joined the channel
Wed May 3 07:17:12 2017  olamy:Joined the channel
Wed May 3 07:18:03 2017  olamy:Joined the channel
Wed May 3 07:18:51 2017  olamy:Joined the channel
Wed May 3 07:19:40 2017  olamy:Joined the channel
Wed May 3 07:20:31 2017  olamy:Joined the channel
Wed May 3 08:05:10 2017  Michael-O:Joined the channel
Wed May 3 08:45:49 2017  tibor_:Joined the channel
Wed May 3 08:46:54 2017  tibor_:@stephenc: Hi Stephen. Is it possible to use two JDKs in our ASF Jenkins? I want to run the build with JDK8 but one specific IT with JDK9.
Wed May 3 08:55:07 2017  tibor_:aheritier: Hi Arno. Do you see my question above? Can you help?
Wed May 3 08:55:21 2017  aheritier:hi tibor_
Wed May 3 08:55:59 2017  aheritier:I'm not admin of this instance I think. I'm not sure how JDK are installed
Wed May 3 08:57:48 2017  aheritier:by default Jenkins installs only one JDK but AFAIR we commonly use this plugin to install more tools/jdks : https://wiki.jenkins-ci.org/display/JENKINS/Custom+Tools+Plugin
Wed May 3 09:12:57 2017  tibor_:aheritier: I found "Tool Environment" and environment variable JDK_9_B156_EARLY_ACCESS_BUILD_WITH_PROJECT_JIGSAW_HOME.
Wed May 3 09:23:39 2017  Michael-O:Joined the channel
Wed May 3 10:11:21 2017  aheritier:I'm not an expert in this setup. olamy isn't here too
Wed May 3 10:11:27 2017  aheritier:or herve
Wed May 3 10:58:14 2017  olamy:Joined the channel
Wed May 3 15:26:58 2017  Michael-O:Joined the channel
Wed May 3 15:34:39 2017  tibor_:Michael-O: Hi Michael. I am still in the office so I must be brief. In the ML I tried to only explain the situation what was before my fix. Nothing special.
Wed May 3 15:40:22 2017  tibor_:What you mean by "location"?
Wed May 3 15:44:06 2017  tibor_:Michael-O: you want me to put a comment in to the code that legacy code took props from main process and commit to branch?
Wed May 3 15:46:29 2017  Michael-O:Actually only this:
Wed May 3 15:47:08 2017  Michael-O:<!-- These files logically belong to this module, but for historic reasons they in the Maven Surefire Plugin module -->
Wed May 3 15:47:35 2017  Michael-O:For an external reader it looks awkward that an schema file is read with ../maven-surefire-plugin/etc..
Wed May 3 15:50:01 2017  tibor_:ah, ok, so we are not talking about SUREFIRE-1364_2, nothing but the previous work in SUREFIRE-1366(javadoc and XSD and site), right?
Wed May 3 15:52:36 2017  Michael-O:Let me check, I am confused too now
Wed May 3 15:52:42 2017  Michael-O:read to much code yesterday
Wed May 3 15:52:56 2017  Michael-O:1366
Wed May 3 15:53:19 2017  Michael-O:Referring to this: https://github.com/apache/maven-surefire/commit/1ca9a35b3fc06b32948105fec1c24e340e974896#commitcomment-21991405
Wed May 3 16:00:54 2017  tibor_:Yes, this PR is about SUREFIRE-1366 - Javadoc. Unfortunately I replied to and the email about new jira issue went there too :)
Wed May 3 16:01:07 2017  tibor_:my bad
Wed May 3 16:24:13 2017  Michael-O:no problem
Wed May 3 16:53:04 2017  rfscholte:Joined the channel
Wed May 3 18:03:53 2017  Michael-O:rfscholte, got at chance to read the outcome of my test?
Wed May 3 18:04:01 2017  Michael-O:Your assumption was right
Wed May 3 18:11:23 2017  rfscholte:reading
Wed May 3 18:16:56 2017  rfscholte:Michael-O: do you need both MSHARED-437 and MNG-5935? Or is just MNG-5935 sufficient?
Wed May 3 18:19:19 2017  rfscholte:you haven't created a branch for MNG-5935 yet, right?
Wed May 3 18:20:59 2017  Michael-O:Only locally, but Christian's patch is simple but good
Wed May 3 18:21:19 2017  Michael-O:I asked Arlo to create a minimal example as an IT for that
Wed May 3 18:21:46 2017  Michael-O:Though, I do not know how to verify that all deps remain optional
Wed May 3 18:23:28 2017  rfscholte:regarding the patch, can't you simply pass dependency.getOptional() ?
Wed May 3 18:23:35 2017  rfscholte:https://git-wip-us.apache.org/repos/asf?p=maven.git;a=blobdiff;f=maven-aether-provider/src/main/java/org/apache/maven/repository/internal/ArtifactDescriptorReaderDelegate.java;h=184c3277003616e7a1acabc98699921c2da99629;hp=2395b36fbd7e04b4f288f2c7f9153de64d590f4b;hb=184f58ff83a6d043c695a07f1b1ae89630f6bc9e;hpb=5cf2b135ca49b3be77ced86d0b44b990b702acab
Wed May 3 18:38:30 2017  Michael-O:I tried, we can't.
Wed May 3 18:38:42 2017  Michael-O:Because one is String and the other is Boolean
Wed May 3 18:38:45 2017  Michael-O:there is a type mismatch
Wed May 3 18:39:41 2017  rfscholte:Ah, ok
Wed May 3 18:39:57 2017  Michael-O:Therefore, Christian's patch makes sense
Wed May 3 18:40:35 2017  Michael-O:Resolver expects a Boolean
Wed May 3 18:40:44 2017  Michael-O:Our Modello model has a string
Wed May 3 18:41:41 2017  rfscholte:Yes, has to do with support of expressions
Wed May 3 18:43:31 2017  Michael-O:Even if I do change maven.mdo, I get a bunch of compile errors.
Wed May 3 18:43:53 2017  Michael-O:You maybe right, expressions require String, but this is counterintuitive
Wed May 3 18:46:54 2017  rfscholte:true. would be great if there was a Modello generator where all fields are String and where you can get the expression or actual value
Wed May 3 18:48:27 2017  Michael-O:How would this be different to the situation now?
Wed May 3 18:48:41 2017  Michael-O:We do have the naked/uninterpolated model, don't we?
Wed May 3 18:48:58 2017  rfscholte:yes
Wed May 3 18:49:57 2017  rfscholte:but everything is a String, not really nice
Wed May 3 19:09:30 2017  Michael-O:Joined the channel
Wed May 3 19:19:18 2017  Michael-O:Joined the channel
Wed May 3 19:37:00 2017  Michael-O:Joined the channel
Wed May 3 19:44:51 2017  Michael-O:Joined the channel
Wed May 3 20:04:46 2017  Michael-O:Joined the channel
Wed May 3 20:06:31 2017  tibor_:Joined the channel
Wed May 3 20:45:14 2017  Michael-O:Joined the channel
Wed May 3 22:28:25 2017  stephenc:Joined the channel
Wed May 3 22:28:51 2017  Michael-O:Joined the channel

Comments