Displaying #maven-dev/2017-05-07.log:

Sun May 7 09:53:15 2017  tibor_:Joined the channel
Sun May 7 10:51:24 2017  olamy:Joined the channel
Sun May 7 11:04:51 2017  hboutemy:Joined the channel
Sun May 7 11:18:31 2017  hboutemy:Joined the channel
Sun May 7 11:32:54 2017  hboutemy:Joined the channel
Sun May 7 11:47:23 2017  hboutemy:Joined the channel
Sun May 7 12:03:46 2017  hboutemy:Joined the channel
Sun May 7 12:19:11 2017  hboutemy:Joined the channel
Sun May 7 12:37:36 2017  hboutemy:Joined the channel
Sun May 7 12:52:02 2017  hboutemy:Joined the channel
Sun May 7 13:10:28 2017  hboutemy:Joined the channel
Sun May 7 13:24:53 2017  hboutemy:Joined the channel
Sun May 7 19:12:10 2017  tibor_:Joined the channel
Sun May 7 20:09:14 2017  Michael-O:Joined the channel
Sun May 7 20:10:05 2017  Michael-O:Has anyone recently run Core ITs on Windows?
Sun May 7 20:10:32 2017  Michael-O:IT for MNG-6210 completely broke the cloning in Git Bash
Sun May 7 20:37:14 2017  Michael-O:Joined the channel
Sun May 7 20:59:17 2017  Michael-O:tibor_, do you have Windows with Git at hand?
Sun May 7 20:59:37 2017  tibor_:yes
Sun May 7 20:59:50 2017  tibor_:what's going on?
Sun May 7 20:59:52 2017  Michael-O:Can you clone maven-integration-testing?
Sun May 7 21:00:03 2017  Michael-O:You should see a checkout failure for MNG-6210
Sun May 7 21:00:30 2017  tibor_:Is it dicussed in ML?
Sun May 7 21:02:10 2017  Michael-O:No, I reopened the ticket but Igor is not willing to fix it.
Sun May 7 21:02:27 2017  Michael-O:I am unable to run any ITs on Windows at the moment
Sun May 7 21:03:50 2017  tibor_:give me our cli to run
Sun May 7 21:03:56 2017  tibor_:any special?
Sun May 7 21:05:12 2017  tibor_:clone is running..
Sun May 7 21:06:06 2017  tibor_:Michael-O: you want the master branch?
Sun May 7 21:09:16 2017  Michael-O:Ye
Sun May 7 21:09:37 2017  Michael-O:The checkout should fail
Sun May 7 21:09:39 2017  tibor_:Michael-O: dammit, clone failed. path too long on Win
Sun May 7 21:10:08 2017  Michael-O:Exactly: https://issues.apache.org/jira/browse/MNG-6210
Sun May 7 21:10:10 2017  tibor_:but there should be some switch to fix this in git
Sun May 7 21:11:18 2017  tibor_:Why somebody checked in mvn repo to git?
Sun May 7 21:11:33 2017  Michael-O:Because he didn't test on Windows but on macOS only
Sun May 7 21:11:40 2017  Michael-O:There won't be any
Sun May 7 21:11:56 2017  Michael-O:the default length is 255 chars on windows
Sun May 7 21:23:27 2017  Michael-O:I obstained to change all the pathes because I did not introduce this commit
Sun May 7 21:26:45 2017  tibor_:Is it normal to commit repo? The repo-src would be just fine. The java package at least could be made shorter.
Sun May 7 21:28:59 2017  hboutemy:Michael-O: ASF Jenkins does the Jenkins build with success
Sun May 7 21:29:22 2017  hboutemy:I suppose your local basedir is a little bit too long
Sun May 7 21:29:39 2017  Michael-O:It is but the basedir is already 242 chars
Sun May 7 21:29:49 2017  Michael-O:if you add maven-integration-testing, you are busting
Sun May 7 21:29:52 2017  Michael-O:busted*
Sun May 7 21:30:03 2017  Michael-O:so regardless what you do, it remains too long
Sun May 7 21:30:13 2017  hboutemy:but for sure, if directory names were a little bit smaller, you'd get more flexibility
Sun May 7 21:30:25 2017  hboutemy:no, the Jenkins ASF server manages it
Sun May 7 21:31:00 2017  hboutemy:isn't it?
Sun May 7 21:31:21 2017  Michael-O:It has to be at most 160 chars
Sun May 7 21:31:42 2017  tibor_:My basedir is E:\
Sun May 7 21:32:07 2017  tibor_:cannt be made shorter
Sun May 7 21:32:11 2017  hboutemy::)
Sun May 7 21:32:18 2017  Michael-O:+ maven-integration-testing....
Sun May 7 21:32:26 2017  tibor_:yes
Sun May 7 21:32:53 2017  hboutemy:you're not even forced to call it "maven-integration-testing"
Sun May 7 21:32:54 2017  tibor_:let me rename the first folder
Sun May 7 21:33:46 2017  tibor_:e:\m is successful but this is a question of time
Sun May 7 21:34:48 2017  Michael-O:I usually don't change clone names
Sun May 7 21:35:03 2017  Michael-O:If it won't break for you, it will break for someone else
Sun May 7 21:35:13 2017  hboutemy:just checked: ASF Jenkins clones the repo to C:\mvn-it-0.tmp
Sun May 7 21:35:49 2017  hboutemy:sure, once again, having smaller directory names in the repo will give more flexibility
Sun May 7 21:36:15 2017  hboutemy:but no, the repo is not *broken* for Windows: it is not flexible
Sun May 7 21:36:54 2017  Michael-O:Agreed
Sun May 7 21:37:28 2017  hboutemy:renaming some directories will give more flexibility, for people manually cloning with default name
Sun May 7 21:37:35 2017  hboutemy:for example
Sun May 7 21:37:40 2017  Michael-O:That's what I asked Igor for
Sun May 7 21:38:07 2017  hboutemy:you'd better do it yourself: it will go faster
Sun May 7 21:39:44 2017  hboutemy:Igor would have done some work on it if the ASF Jenkins server would not have been able to clone the repo
Sun May 7 21:40:07 2017  tibor_:See the package lenght
Sun May 7 21:40:08 2017  tibor_:src/main/java/org/apache/maven/its/core_extensions_custom_scopes/plugin/ValidateMojoExecutionScopedMojo.java: Filename too long
Sun May 7 21:40:19 2017  tibor_:core_extensions_custom_scopes
Sun May 7 21:40:34 2017  tibor_:long isn't it?
Sun May 7 21:40:50 2017  hboutemy:when you're not on WIndows, you prefer explicit names
Sun May 7 21:41:12 2017  hboutemy:when you're on Windows, some stupid limitations like this change your priorities :)
Sun May 7 21:41:46 2017  tibor_:extension is enough
Sun May 7 21:41:57 2017  hboutemy:and unless you have a WIndows box that shows you you're hitting the limit, you stay with your initial priority: explicit names
Sun May 7 21:42:15 2017  hboutemy:yes, IMHO, just renaming this part is quick and sufficient
Sun May 7 21:44:20 2017  Michael-O:tibor_, I think the package name won't do it
Sun May 7 21:44:53 2017  hboutemy:why?
Sun May 7 21:45:19 2017  Michael-O:This is long: $ cd mng-62
Sun May 7 21:45:20 2017  Michael-O:mng-6209-multiple-build-extensions/ mng-6210-core-extensions-custom-scopes/
Sun May 7 21:45:38 2017  Michael-O:[mosipov@bsd1home ~/Projekte/maven-integration-testing/core-it-suite/src/test/resources/mng-6210-core-extensions-custom-scopes]$ tree
Sun May 7 21:45:38 2017  Michael-O:.
Sun May 7 21:45:38 2017  Michael-O:├── client
Sun May 7 21:45:38 2017  Michael-O:│   └── pom.xml
Sun May 7 21:45:38 2017  Michael-O:├── repo
Sun May 7 21:45:40 2017  Michael-O:│   └── org
Sun May 7 21:45:42 2017  Michael-O:│   └── apache
Sun May 7 21:45:44 2017  Michael-O:│   └── maven
Sun May 7 21:45:46 2017  Michael-O:│   └── its
Sun May 7 21:45:48 2017  Michael-O:│   └── it-core-extensions-custom-scopes
Sun May 7 21:45:50 2017  Michael-O:│   ├── maven-it-core-extensions-custom-scopes
Sun May 7 21:45:51 2017  Michael-O:│   │   ├── 0.1
Sun May 7 21:45:54 2017  Michael-O:│   │   │   ├── maven-it-core-extensions-custom-scopes-0.1.jar
Sun May 7 21:45:56 2017  Michael-O:│   │   │   └── maven-it-core-extensions-custom-scopes-0.1.pom
Sun May 7 21:45:58 2017  Michael-O:│   │   └── maven-metadata.xml
Sun May 7 21:46:00 2017  Michael-O:│   ├── maven-it-plugin-core-extensions-custom-scopes-client
Sun May 7 21:46:02 2017  Michael-O:│   │   ├── 0.1
Sun May 7 21:46:06 2017  Michael-O:│   │   │   ├── maven-it-plugin-core-extensions-custom-scopes-client-0.1.jar
Sun May 7 21:46:09 2017  Michael-O:│   │   │   └── maven-it-plugin-core-extensions-custom-scopes-client-0.1.pom
Sun May 7 21:46:12 2017  Michael-O:│   │   └── maven-metadata.xml
Sun May 7 21:46:14 2017  Michael-O:│   └── maven-metadata.xml
Sun May 7 21:46:16 2017  Michael-O:├── repo-src
Sun May 7 21:46:18 2017  Michael-O:│   ├── maven-it-core-extensions-custom-scopes
Sun May 7 21:46:20 2017  Michael-O:│   │   ├── pom.xml
Sun May 7 21:46:22 2017  Michael-O:│   │   └── src
Sun May 7 21:46:24 2017  Michael-O:│   │   └── main
Sun May 7 21:46:26 2017  Michael-O:│   │   ├── java
Sun May 7 21:46:28 2017  Michael-O:│   │   │   └── org
Sun May 7 21:46:30 2017  Michael-O:│   │   │   └── apache
Sun May 7 21:46:32 2017  Michael-O:│   │   │   └── maven
Sun May 7 21:46:36 2017  Michael-O:│   │   │   └── its
Sun May 7 21:46:38 2017  Michael-O:│   │   │   └── core_extensions_custom_scopes
Sun May 7 21:46:40 2017  Michael-O:│   │   │   ├── TestMojoExecutionScopedComponent.java
Sun May 7 21:46:40 2017  hboutemy:you mean: you need to change groupId/artifactId also?
Sun May 7 21:46:42 2017  Michael-O:│   │   │   └── TestSessionScopedComponent.java
Sun May 7 21:46:44 2017  Michael-O:│   │   └── resources
Sun May 7 21:46:46 2017  Michael-O:│   │   └── META-INF
Sun May 7 21:46:48 2017  Michael-O:│   │   └── maven
Sun May 7 21:46:49 2017  hboutemy:just do it!
Sun May 7 21:46:50 2017  Michael-O:│   │   └── extension.xml
Sun May 7 21:46:52 2017  Michael-O:│   └── maven-it-plugin-core-extensions-custom-scopes-client
Sun May 7 21:46:54 2017  Michael-O:│   ├── pom.xml
Sun May 7 21:46:56 2017  Michael-O:│   └── src
Sun May 7 21:46:58 2017  Michael-O:│   └── main
Sun May 7 21:47:00 2017  Michael-O:│   └── java
Sun May 7 21:47:02 2017  Michael-O:│   └── org
Sun May 7 21:47:06 2017  Michael-O:│   └── apache
Sun May 7 21:47:08 2017  Michael-O:│   └── maven
Sun May 7 21:47:10 2017  Michael-O:│   └── its
Sun May 7 21:47:12 2017  Michael-O:│   └── core_extensions_custom_scopes
Sun May 7 21:47:14 2017  Michael-O:│   └── plugin
Sun May 7 21:47:16 2017  Michael-O:│   ├── ValidateMojoExecutionScopedMojo.java
Sun May 7 21:47:18 2017  Michael-O:│   └── ValidateSessionScopedMojo.java
Sun May 7 21:47:20 2017  Michael-O:└── settings-template.xml
Sun May 7 21:47:22 2017  hboutemy:copy/paste os not a good idea...
Sun May 7 21:47:22 2017  Michael-O:the filenames may also kill it
Sun May 7 21:47:50 2017  Michael-O:$ ls -R . | awk '
Sun May 7 21:47:50 2017  Michael-O:NF&&f{ print s"/"$0 }'
Sun May 7 21:48:01 2017  Michael-O:here is a script for the flat length
Sun May 7 21:48:08 2017  hboutemy:once again, you know how much flexibility you want to keep
Sun May 7 21:48:24 2017  Michael-O:+ add length("maven-integration-testing/core-it-suite/src/test/resources/mng-6210-core-extensions-custom-scopes")
Sun May 7 21:48:42 2017  Michael-O:I'd keep at least 30 chars for the user, or even more
Sun May 7 21:49:24 2017  hboutemy:if this convention can be checked automatically, you'll win
Sun May 7 21:49:45 2017  hboutemy:if it is not, you'll do the manual change when someone misses it
Sun May 7 21:50:06 2017  hboutemy:because the current convention is: it has to work on ASF Jenkins
Sun May 7 21:50:25 2017  hboutemy:(and you don't need personal Windiws machine to test locally)
Sun May 7 21:50:41 2017  Michael-O:Though, we always do test locally first
Sun May 7 21:51:06 2017  hboutemy:on your local OS? yes
Sun May 7 21:51:24 2017  hboutemy:but I never tested on OSX: I don't have such machine
Sun May 7 21:51:43 2017  hboutemy:and I don't take time to launch a Windows VM to check
Sun May 7 21:52:04 2017  hboutemy:ASF Jenkins is there to do the multi-platform check
Sun May 7 21:53:21 2017  tibor_:I have made some experiments and renamed core_extensions_custom_scopes -> mng6210, total length changed from 272 to 250 chars
Sun May 7 21:54:05 2017  tibor_:shorten maven-it-plugin-core-extensions-custom-scopes-client folder even better
Sun May 7 21:54:09 2017  hboutemy:by total, you mean with your local basedir?
Sun May 7 21:54:13 2017  Michael-O:hboutemy, it should have failed even on Jenkins: d:\mvn-it-0.tmp/core-it-suite/src/test/resources/mng-6210-core-extensions-custom-scopes/repo-src/maven-it-plugin-core-extensions-custom-scopes-client/src/main/java/org/apache/maven/its/core_extensions_custom_scopes/plugin/ValidateMojoExecutionScopedMojo.java
Sun May 7 21:54:24 2017  Michael-O:This is 258 chars long
Sun May 7 21:54:26 2017  tibor_:total = absolute
Sun May 7 21:54:27 2017  Michael-O:too long for windows
Sun May 7 21:54:45 2017  tibor_:e:\maven-integration-testing\core-it-suite\src\test\resources\mng-6210-core-extensions-custom-scopes\repo-src\maven-it-plugin-core-extensions-custom-scopes-client\src\main\java\org\apache\maven\its\mng6210\plugin\ValidateMojoExecutionScopedMojo.java
Sun May 7 21:55:00 2017  hboutemy:my question is just to know if the value is tied to a local choice of basedir or not
Sun May 7 21:55:41 2017  Michael-O:the smallest basedir is c:\1
Sun May 7 21:55:41 2017  hboutemy:I suppose that the limit was not hit too much: perhaps the filename was used as 8.3
Sun May 7 21:55:56 2017  Michael-O:I don't think that NTFS does that
Sun May 7 21:56:15 2017  hboutemy:I don't think as theorician but as pratician: if Jenkins ASF managed to build it, it works
Sun May 7 21:56:49 2017  hboutemy:and if you tell it can't, the ASF Jenkins proves the contrary: I don't know why
Sun May 7 21:57:17 2017  Michael-O:Unfortunately, the Jenkinsfile deletes the working area
Sun May 7 21:57:25 2017  Michael-O:I can't browse to verify
Sun May 7 21:57:34 2017  hboutemy:yes...
Sun May 7 21:57:41 2017  hboutemy:or I don't know how to do it
Sun May 7 21:58:31 2017  hboutemy:time for me to sleep
Sun May 7 21:58:40 2017  hboutemy:good night folks :)
Sun May 7 21:59:05 2017  Michael-O:night
Sun May 7 22:04:38 2017  Michael-O:tibor_, Igor shortened already down
Sun May 7 22:04:48 2017  tibor_:ok
Sun May 7 22:05:33 2017  tibor_:Does Jenkins perform git clone on Ubuntu?
Sun May 7 22:06:03 2017  Michael-O:Yes
Sun May 7 22:06:20 2017  Michael-O:I still don't understand why Windows node worked
Sun May 7 22:06:21 2017  tibor_:So this is only personal issue?
Sun May 7 22:07:13 2017  Michael-O:I don't think so
Sun May 7 22:07:20 2017  Michael-O:Likely no one complained yet
Sun May 7 22:08:51 2017  Michael-O:I am going offline
Sun May 7 22:08:56 2017  Michael-O:need some sleep
Sun May 7 22:09:56 2017  tibor_:git config --system core.longpaths true
Sun May 7 22:10:00 2017  tibor_:does the trick
Sun May 7 22:10:29 2017  tibor_:Michael-O: git config --system core.longpaths true
Sun May 7 22:10:51 2017  tibor_:git clone was successful after this
Sun May 7 22:13:20 2017  Michael-O:https://github.com/msysgit/git/pull/122
Sun May 7 22:16:55 2017  Michael-O:Here is the commit: https://github.com/kasal/git/commit/a0e78a575ec4f7093df8d466b3949ac859bb78d1
Sun May 7 22:17:26 2017  Michael-O:One should really search for this an hour or enable this for just one IT

Comments