Displaying #maven-dev/2017-08-12.log:

Sat Aug 12 07:18:30 2017  rfscholte:Joined the channel
Sat Aug 12 08:04:25 2017  rfscholte:Joined the channel
Sat Aug 12 10:39:01 2017  olamy:Joined the channel
Sat Aug 12 15:39:54 2017  Michael-O:Joined the channel
Sat Aug 12 15:44:26 2017  khmarbaise:Joined the channel
Sat Aug 12 16:28:23 2017  rfscholte:khmarbaise: HI Karl Heinz, java9-modules-maven-junit-example-jdk9-fixing works on my machine
Sat Aug 12 16:28:53 2017  khmarbaise:Hm…interesting..? Do you use toolchains or using JDK 9 for running Maven as well ß
Sat Aug 12 16:28:58 2017  khmarbaise:s/ß/?/
Sat Aug 12 16:29:10 2017  khmarbaise:running on the correct branch ?
Sat Aug 12 16:29:24 2017  rfscholte:I use toolchains
Sat Aug 12 16:29:29 2017  khmarbaise:Ok…Hm...
Sat Aug 12 16:29:45 2017  khmarbaise:using same JDK9+181 I assume?
Sat Aug 12 16:29:58 2017  rfscholte:just downloaded it
Sat Aug 12 16:30:04 2017  khmarbaise:Ok…
Sat Aug 12 16:30:09 2017  khmarbaise:which Maven version?
Sat Aug 12 16:30:19 2017  khmarbaise:I’m using Maven 3.5.0..
Sat Aug 12 16:30:28 2017  rfscholte:me too
Sat Aug 12 16:30:46 2017  rfscholte:but it says "failed to parse module-info"
Sat Aug 12 16:31:01 2017  khmarbaise:On your site ?
Sat Aug 12 16:31:04 2017  rfscholte:that's either a problem with the file or the JDK
Sat Aug 12 16:31:12 2017  rfscholte:in your message
Sat Aug 12 16:31:30 2017  khmarbaise:Ah..misunderstanding…thought you can reproduce it ;-(
Sat Aug 12 16:31:39 2017  rfscholte:which command are you running?
Sat Aug 12 16:31:49 2017  khmarbaise:mvn clean package
Sat Aug 12 16:32:20 2017  rfscholte:BUILD SUCCESS
Sat Aug 12 16:33:00 2017  khmarbaise:Hm..based on the code in maven-compiler-plugin (CompilerMojo.java) exception IOException must be through…to get this message…(Line 184)...
Sat Aug 12 16:33:17 2017  khmarbaise:s/through/thrown/...
Sat Aug 12 16:33:25 2017  rfscholte:are you sure you're not using an older JDK, that would explain the Exception...
Sat Aug 12 16:33:47 2017  khmarbaise:Hm..but let me double check that…
Sat Aug 12 16:34:55 2017  khmarbaise:In the log file I have is printed out “…/jdk1.9.0_ea+181/…” for javac (executable)...
Sat Aug 12 16:35:51 2017  khmarbaise:Rechecked..java version "9"
Sat Aug 12 16:35:51 2017  khmarbaise:Java(TM) SE Runtime Environment (build 9+181)
Sat Aug 12 16:35:51 2017  khmarbaise:Java HotSpot(TM) 64-Bit Server VM (build 9+181, mixed mode)
Sat Aug 12 16:36:20 2017  khmarbaise:But give me sometime I will check some other things...
Sat Aug 12 16:37:00 2017  rfscholte:that's the version picked up by toolchains?
Sat Aug 12 16:39:21 2017  khmarbaise:Now I have use JDK 9 for runtime for Maven as well to compile without toolchain and not it works…
Sat Aug 12 16:39:25 2017  khmarbaise:without any issue...
Sat Aug 12 16:40:35 2017  khmarbaise:Yeah that is the version picked up by toolchain…
Sat Aug 12 16:41:20 2017  rfscholte:I've seen ordering issues when using toolchains, maybe something to be aware of
Sat Aug 12 16:42:27 2017  rfscholte:in your exception I didn't see something like [INFO] Toolchain in maven-compiler-plugin: JDK[c:\Program Files\Java\jdk-9]
Sat Aug 12 16:42:49 2017  khmarbaise:I can send you the whole log file if you like...
Sat Aug 12 16:43:00 2017  khmarbaise:maybe I cut out this output...
Sat Aug 12 16:43:58 2017  khmarbaise:Ordering issue with toolchains..?
Sat Aug 12 16:45:56 2017  rfscholte:yes, suppose you want to build a Java6 project, and you defined 7,8 and 9 (all valid) then it could happen that is not picking up the first matching toolchain. Looks like this is not a LinkedHashmap...
Sat Aug 12 16:48:20 2017  rfscholte:brb
Sat Aug 12 16:52:37 2017  khmarbaise:Have checked and defined only a single entry in toolchains.xml with the same result...
Sat Aug 12 16:56:16 2017  khmarbaise:So it looks like it can’t be an ordering issue from toolchains…
Sat Aug 12 17:09:57 2017  rfscholte:I HAVE THE ANSWER :) (some shopping cleared my mind)
Sat Aug 12 17:10:58 2017  rfscholte:in short: the issue is a dependency on the asm-6.0_ALPHA
Sat Aug 12 17:11:04 2017  rfscholte:i will prepare the mail
Sat Aug 12 17:15:37 2017  khmarbaise:Great…;-)
Sat Aug 12 17:15:52 2017  khmarbaise:So a newer version or the version currently used by maven-compiler-plugin ?
Sat Aug 12 17:19:31 2017  khmarbaise:https://mail.ow2.org/wws/arc/asm/2017-08/msg00000.html there is a hint “does not work with javac 9 (yet !)” ?
Sat Aug 12 17:20:55 2017  khmarbaise:Tested with ASM 6.0 BETA but does not work either...
Sat Aug 12 17:22:37 2017  khmarbaise:Got the fix YIPPIE….;-) ;-)....
Sat Aug 12 17:22:59 2017  khmarbaise:rfscholte: Got it working….
Sat Aug 12 17:25:18 2017  rfscholte:Good, just read my mail for all the details. you should have it by now
Sat Aug 12 17:26:54 2017  rfscholte:khmarbaise: please let me fix MCOMPILER-303
Sat Aug 12 17:27:36 2017  rfscholte:or accept that a part of it will be replaced in the near future :)
Sat Aug 12 17:27:36 2017  khmarbaise:I don’t know why but I have already the fix here just need to commit but if you really want just go for it…
Sat Aug 12 17:29:09 2017  rfscholte:could you have a look at https://github.com/codehaus-plexus/plexus-languages ?
Sat Aug 12 17:31:50 2017  khmarbaise:Ok done so…
Sat Aug 12 17:33:55 2017  khmarbaise:Just a short hint related to your email…I’m using toolchains which now works based on the fixed in compiler-plugin (upgraded ASM to BETA..) and added the code which was outcommented…AsmModuleInfoParser…
Sat Aug 12 17:40:16 2017  rfscholte:yes, asm is the preferred way. code was already prepared but simply not released.... :(
Sat Aug 12 17:41:13 2017  khmarbaise:Hm..? 6.0_BETA is in Maven Central or do i misunderstand a thing here ?
Sat Aug 12 17:42:30 2017  rfscholte:yes, now it is but that took a very long time.
Sat Aug 12 17:42:44 2017  rfscholte:compiler-plugin was already prepared to pick up that code
Sat Aug 12 17:43:01 2017  khmarbaise:compiler-plugin will work with this change now…
Sat Aug 12 17:43:35 2017  khmarbaise:So the question is would you go for plexus-languages or should we continue to make the needed changes in maven-compiler-pluing ß
Sat Aug 12 17:43:44 2017  khmarbaise:s/ß/?/
Sat Aug 12 17:45:40 2017  khmarbaise:btw. why not making the plexus-languages a shared component in Apache ? Reasons for that ?
Sat Aug 12 17:47:12 2017  rfscholte:I want it to be available for more users. Making it a maven-shared component will block that probably
Sat Aug 12 17:48:05 2017  rfscholte:it must be clear that is has nothing to do with Maven. I avoided terms like dependencies and artifacts for that
Sat Aug 12 17:49:01 2017  khmarbaise:Ah..you wan’t a reusable component which is concentrated only on module/ etc. in JDK 9 (and maybe above)…
Sat Aug 12 17:53:06 2017  rfscholte:yes
Sat Aug 12 17:53:53 2017  rfscholte:and I've started JavaVersion as well. that's something which is implemented over and over again. Let's bundle it here
Sat Aug 12 17:54:19 2017  khmarbaise:Already seen that….good idea…
Sat Aug 12 17:55:50 2017  khmarbaise:That looks like removing the whole package “module” in compiler-plugin and reuse the plexus-languages component ?…
Sat Aug 12 18:17:35 2017  rfscholte:yes indeed
Sat Aug 12 18:19:36 2017  khmarbaise:just a question for my understanding…I’m trying to understand a thing in maven-compiler-plugin. It looks like that each argument which is given via compilerAgs which starts with “-J” will be ignored ? Maybe I misundertand a thing but is this correct ?
Sat Aug 12 18:20:12 2017  khmarbaise:The remove is done in plexus-compiler-javac component ?
Sat Aug 12 18:43:23 2017  rfscholte:haven't dived into that.
Sat Aug 12 18:46:43 2017  khmarbaise:At the moment it looks like that runtime options “-J” will be removed silently…the given example in the docs http://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#compilerArgs will not work as well cause the option “-J” is removed from the arguments…(MCOMPILER-297)…
Sat Aug 12 18:54:50 2017  khmarbaise:So furthermore information about the “-J” options are not allowed in @file …http://docs.oracle.com/javase/7/docs/technotes/tools/windows/javac.html#commandlineargfile …so this will be the reason...
Sat Aug 12 18:55:01 2017  khmarbaise:but this looks like an docs issue…
Sat Aug 12 19:05:46 2017  khmarbaise:rfscholte: I want to fix MCOMPILER-289 (by upgrading QDox to 2.0-M7) would that be ok cause you are already assigned to that ?
Sat Aug 12 19:19:28 2017  rfscholte:you can do that
Sat Aug 12 19:20:13 2017  rfscholte:but once plexus-java is introduced, qdox is no direct dependency anymore
Sat Aug 12 20:06:22 2017  tibor_:Joined the channel
Sat Aug 12 20:07:55 2017  tibor_:@rfscholte: Hi Robert. I finished Java 9 support in Surefire (Jira 1403). I need someone to have a look. Do you have time?
Sat Aug 12 20:23:06 2017  rfscholte:tibor_: will do it tomorrow

Comments