Displaying #maven-dev/2017-08-31.log:

Thu Aug 31 00:15:39 2017  theRealGent:Joined the channel
Thu Aug 31 04:18:42 2017  mbenson_:Joined the channel
Thu Aug 31 11:07:39 2017  olamy:Joined the channel
Thu Aug 31 16:53:16 2017  rfscholte:Joined the channel
Thu Aug 31 18:25:08 2017  rfscholte:Joined the channel
Thu Aug 31 18:41:46 2017  hboutemy:Joined the channel
Thu Aug 31 18:56:57 2017  hboutemy:Joined the channel
Thu Aug 31 19:15:08 2017  hboutemy:Joined the channel
Thu Aug 31 19:33:44 2017  hboutemy:Joined the channel
Thu Aug 31 19:52:55 2017  hboutemy:Joined the channel
Thu Aug 31 20:11:37 2017  hboutemy:Joined the channel
Thu Aug 31 20:29:43 2017  hboutemy:Joined the channel
Thu Aug 31 20:45:39 2017  tibor_:Joined the channel
Thu Aug 31 20:48:24 2017  hboutemy:Joined the channel
Thu Aug 31 21:00:41 2017  rfscholte:tibor_: ping
Thu Aug 31 21:03:19 2017  tibor_:Hi Robert
Thu Aug 31 21:03:25 2017  tibor_:What's up
Thu Aug 31 21:03:31 2017  rfscholte:Hi Tibor,
Thu Aug 31 21:03:45 2017  rfscholte:i was wondering what's the status of surefire
Thu Aug 31 21:04:03 2017  tibor_:What you mean. I am in progress.
Thu Aug 31 21:04:09 2017  rfscholte:especially with regards to Java 9
Thu Aug 31 21:04:23 2017  tibor_:Few bugs to fix and then cut release in cca 2 weeks.
Thu Aug 31 21:04:44 2017  rfscholte:including running modular projects?
Thu Aug 31 21:04:55 2017  tibor_:no, of course not
Thu Aug 31 21:05:06 2017  tibor_:but we had an email
Thu Aug 31 21:05:30 2017  rfscholte:I have a couple of names who are willing to help on that subject
Thu Aug 31 21:05:35 2017  tibor_:there is one showstopper
Thu Aug 31 21:05:51 2017  rfscholte:which is?
Thu Aug 31 21:06:01 2017  tibor_:I am trying to explain
Thu Aug 31 21:06:33 2017  hboutemy:Joined the channel
Thu Aug 31 21:06:37 2017  tibor_:basically you can try but I think it will be not that easy
Thu Aug 31 21:07:47 2017  tibor_:filtering of tests is performed in plugin in IsolatedCL
Thu Aug 31 21:08:43 2017  tibor_:it would be good to make it in the forked jvm, but then the communication channel between processes must change
Thu Aug 31 21:09:57 2017  tibor_:as I said somebody may try in a branch but this filtering should be reworked anyway. If you change surefire then I think I will have more work.
Thu Aug 31 21:11:10 2017  tibor_:@rfscholte: you'r idle
Thu Aug 31 21:11:19 2017  rfscholte:I'll leave that issue up to you.
Thu Aug 31 21:11:37 2017  tibor_:but I need a help anyway because I am alone
Thu Aug 31 21:11:39 2017  tibor_:look
Thu Aug 31 21:12:08 2017  rfscholte:recognizing that :|
Thu Aug 31 21:12:25 2017  tibor_:if you find a guy who can help me and start with this in a branch we can always benefit from his time spent
Thu Aug 31 21:12:47 2017  rfscholte:I've fixed quite a lot for Java9, but surefire is that one final piece
Thu Aug 31 21:12:55 2017  tibor_:I know
Thu Aug 31 21:13:11 2017  tibor_:currently I have fixed my own issue I caused
Thu Aug 31 21:13:20 2017  tibor_:therefore not yet in 3.0
Thu Aug 31 21:13:37 2017  rfscholte:ok, that's fine for me.
Thu Aug 31 21:13:40 2017  tibor_:I have one support from ASF
Thu Aug 31 21:13:55 2017  tibor_:the guy works for Apache Commons
Thu Aug 31 21:14:12 2017  tibor_:and he is writing Surefire provider for JUnit5 + ITs
Thu Aug 31 21:14:39 2017  tibor_:I will have some work to pick his commits and squash them on to master 3.0
Thu Aug 31 21:15:43 2017  rfscholte:how about if I start a branch just for these Java 9 stuff, and maybe do a specific 2.x-jigsaw release
Thu Aug 31 21:16:18 2017  rfscholte:you can do your work in the meantime
Thu Aug 31 21:16:52 2017  tibor_:yeah, that's very good staring point
Thu Aug 31 21:17:01 2017  rfscholte:great
Thu Aug 31 21:17:59 2017  rfscholte:should I create a branch based on 2.20? 2.19.1?
Thu Aug 31 21:18:30 2017  tibor_:you can do it on the top of current master. It's stable.
Thu Aug 31 21:19:06 2017  rfscholte:ok, even better
Thu Aug 31 21:19:19 2017  tibor_:we will fix only such issues till 2.20.1 which do not break public methods and compatibility, no worries
Thu Aug 31 21:20:21 2017  tibor_:parallel computer and scanning dependencies in AbstractSurefireMojo is pending issues to fix
Thu Aug 31 21:21:18 2017  tibor_:now I am working on scanning dependencies in AbstractSurefireMojo
Thu Aug 31 21:25:14 2017  hboutemy:Joined the channel
Thu Aug 31 21:27:36 2017  tibor_:wow, my tests passed on SUREFIRE-1383
Thu Aug 31 21:29:45 2017  rfscholte:nice
Thu Aug 31 21:35:33 2017  tibor_:I am working on it with one contributor on GitHub in pull request.
Thu Aug 31 21:39:56 2017  hboutemy:Joined the channel
Thu Aug 31 21:43:20 2017  tibor_:@rfscholte: You want to filter modules and multiversion jar as well? What kind of config parameter you plan to introduce?
Thu Aug 31 21:44:45 2017  tibor_:@rfscholte: Take a look into history of ForkingConfiguration.java. I guess you should switch off --add-module I added.
Thu Aug 31 21:44:46 2017  rfscholte:no, I don't. multiversion is very, very tricky
Thu Aug 31 21:45:17 2017  rfscholte:thanks for the hint
Thu Aug 31 21:46:29 2017  tibor_:it means without modular jars --add-module stays.
Thu Aug 31 21:47:21 2017  tibor_:this class creates jar file
Thu Aug 31 21:47:50 2017  tibor_:I think you would not need to have jar file anymore, and the only meta file and CLI
Thu Aug 31 21:49:52 2017  rfscholte:we'll see :)
Thu Aug 31 21:52:48 2017  tibor_:I guess you would scan target/classes and target/*.jar if there is module-info.class, see DependencyScanner and DirectoryScanner. We scan *.class but you can extend it.
Thu Aug 31 21:53:55 2017  rfscholte:I'm going to use plexus-java, which can decide where jars belong: modulepath or classpath
Thu Aug 31 21:54:02 2017  tibor_:We have a functionality which determines version of JDK in Toolchain.
Thu Aug 31 21:57:37 2017  hboutemy:Joined the channel
Thu Aug 31 22:09:47 2017  tibor_:@rfscholte: module-info.java must be written by the user who runs test, right? I am asking because a feature dependenciesToScan would not be applicable. Not sure which other filtering as well.
Thu Aug 31 22:16:16 2017  hboutemy:Joined the channel
Thu Aug 31 22:21:54 2017  tibor_:We should note in the documentation that these parameters are not applicable in Surefire@Jigsaw: classpathDependencyExcludes, classpathDependencyScopeExclude, dependenciesToScan.
Thu Aug 31 22:25:22 2017  tibor_:These too: useManifestOnlyJar. Problem will be with useSystemClassLoader - used in plugin and IsolatedCL shold not take SystemCL in Surefire@Jigsaw IMHO.
Thu Aug 31 22:28:31 2017  rfscholte:let's first make things working, but it's good to keep this in mind
Thu Aug 31 22:33:20 2017  rfscholte:time to sleep, will pick this up tomorrow
Thu Aug 31 22:34:24 2017  hboutemy:Joined the channel
Thu Aug 31 22:53:02 2017  hboutemy:Joined the channel
Thu Aug 31 23:12:14 2017  hboutemy:Joined the channel
Thu Aug 31 23:29:53 2017  hboutemy:Joined the channel
Thu Aug 31 23:49:04 2017  hboutemy:Joined the channel

Comments