Displaying #maven-dev/2017-09-16.log:

Sat Sep 16 00:04:13 2017  hboutemy:Joined the channel
Sat Sep 16 00:21:54 2017  hboutemy:Joined the channel
Sat Sep 16 00:40:03 2017  hboutemy:Joined the channel
Sat Sep 16 00:57:43 2017  hboutemy:Joined the channel
Sat Sep 16 01:15:55 2017  hboutemy:Joined the channel
Sat Sep 16 01:34:46 2017  hboutemy:Joined the channel
Sat Sep 16 01:52:45 2017  hboutemy:Joined the channel
Sat Sep 16 02:10:22 2017  hboutemy:Joined the channel
Sat Sep 16 02:44:04 2017  hboutemy:Joined the channel
Sat Sep 16 03:02:41 2017  hboutemy:Joined the channel
Sat Sep 16 03:20:55 2017  hboutemy:Joined the channel
Sat Sep 16 03:39:02 2017  hboutemy:Joined the channel
Sat Sep 16 03:57:45 2017  hboutemy:Joined the channel
Sat Sep 16 04:16:24 2017  hboutemy:Joined the channel
Sat Sep 16 04:25:39 2017  ASFBot:Joined the channel
Sat Sep 16 04:34:04 2017  hboutemy:Joined the channel
Sat Sep 16 04:53:02 2017  hboutemy:Joined the channel
Sat Sep 16 05:11:25 2017  hboutemy:Joined the channel
Sat Sep 16 05:45:04 2017  hboutemy:Joined the channel
Sat Sep 16 06:02:44 2017  hboutemy:Joined the channel
Sat Sep 16 06:21:24 2017  hboutemy:Joined the channel
Sat Sep 16 06:40:05 2017  hboutemy:Joined the channel
Sat Sep 16 06:49:47 2017  olamy:Joined the channel
Sat Sep 16 06:54:40 2017  hboutemy:Joined the channel
Sat Sep 16 07:28:45 2017  olamy:Joined the channel
Sat Sep 16 07:28:55 2017  hboutemy:Joined the channel
Sat Sep 16 07:47:34 2017  hboutemy:Joined the channel
Sat Sep 16 08:05:15 2017  hboutemy:Joined the channel
Sat Sep 16 08:23:54 2017  hboutemy:Joined the channel
Sat Sep 16 08:41:32 2017  hboutemy:Joined the channel
Sat Sep 16 08:45:28 2017  rfscholte:Joined the channel
Sat Sep 16 09:48:39 2017  olamy:Joined the channel
Sat Sep 16 09:52:47 2017  stephenc:hboutemy: rfscholte: yt?
Sat Sep 16 09:53:16 2017  stephenc:is another Saturday morning, at the side of another GAA pitch
Sat Sep 16 09:53:34 2017  rfscholte:I'm here
Sat Sep 16 09:56:29 2017  stephenc:So the tccl thing is confusing me
Sat Sep 16 09:56:49 2017  stephenc:Before, tccl was always plugin realm...
Sat Sep 16 09:57:17 2017  stephenc:Now tccl is project realm if the plugin says "I have extensions" and plugin realm otherwise
Sat Sep 16 09:57:46 2017  stephenc:I am wondering why we'd ever set tccl to other than project realm
Sat Sep 16 09:57:46 2017  rfscholte:I would expect it to be the other way around
Sat Sep 16 09:58:29 2017  stephenc:If a plugin says "I have extensions" then it's classloader *i expect* should have been merged into project realm
Sat Sep 16 09:58:50 2017  stephenc:And hence, tccl should be project realm always
Sat Sep 16 09:58:57 2017  rfscholte:so in case of a packaging plugin, which contains components for archiving, it must be exposed to project. Plugin realm should stay the same
Sat Sep 16 09:59:35 2017  stephenc:Yes, but what should the tccl be for the plugin itself when the plugin is executing?
Sat Sep 16 10:00:03 2017  stephenc:To me, it seems this change is only half a fix
Sat Sep 16 10:00:34 2017  rfscholte:let me have a look at that change again
Sat Sep 16 10:00:44 2017  stephenc:I'd have to add <extensions>true to the jar plugin to pick up an extension from another plugin iiuc
Sat Sep 16 10:01:59 2017  stephenc:I don't want to release 3.5.1 unless we can release note this well
Sat Sep 16 10:02:39 2017  rfscholte:yeah, this classloader stuff is very tricky and must be stable
Sat Sep 16 10:03:53 2017  stephenc:I don't mind releasing 3.5.1 with these changes as long as we understand what the impact is and we are sure they are "correct"
Sat Sep 16 10:04:03 2017  rfscholte:+1
Sat Sep 16 10:04:40 2017  stephenc:But right now I am uncomfortable with the tccl change as it seems, at first glance, a half-baked fix
Sat Sep 16 10:06:22 2017  stephenc:6275 is more a "necessary evil", so I am fine with that breaking embedder use by eclipse
Sat Sep 16 10:07:08 2017  stephenc:I'd be happier if it wasn't breaking eclipse... but CLI actually working is priority and I do not see another way to fix
Sat Sep 16 10:08:01 2017  stephenc:But MNG-6209...
Sat Sep 16 10:09:11 2017  stephenc:Now if we determine that tccl should be always project realm (i.e. 6209 is only a half-fix) I am fine with releasing with a release note
Sat Sep 16 10:09:28 2017  rfscholte:reading all comments on https://issues.apache.org/jira/browse/MNG-6209
Sat Sep 16 10:13:11 2017  stephenc:Seems clear that tccl use by assembly (and other plugins) is probably a bug
Sat Sep 16 10:13:41 2017  stephenc:Though that could be an argument that we shouldn't set tccl at all ;-)
Sat Sep 16 10:13:57 2017  rfscholte:my idea too :)
Sat Sep 16 10:18:23 2017  rfscholte:Shouldn't be too hard to verify this, I guess. 1 project with 2 plugins with both extensions = true. One plugin should not be able to access classes from other plugin, right?
Sat Sep 16 10:18:39 2017  stephenc:But should see extensions
Sat Sep 16 10:19:04 2017  rfscholte:yes
Sat Sep 16 10:19:45 2017  stephenc:And similarly, if the second plugin has extensions fals
Sat Sep 16 10:20:13 2017  stephenc:It should see the extensions from the first plugin but the first shouldn't see extensions from second
Sat Sep 16 10:21:05 2017  stephenc:And a plugin should always see its own extensions irrespective of how it set extensions
Sat Sep 16 10:21:59 2017  stephenc:If there are two plugins implemented extensions
Sat Sep 16 10:23:00 2017  stephenc:1=true,2=true, then when 2 is executed, should see extensions in "pom" order in case of overlap
Sat Sep 16 10:23:52 2017  stephenc:1=true,2=false when 2 executed, should see own extensions first, then project extensions in pom order
Sat Sep 16 10:24:54 2017  rfscholte:this one is interesting
Sat Sep 16 10:25:06 2017  rfscholte:assume 1 is m-jar-p
Sat Sep 16 10:25:10 2017  stephenc:1=false,2=false doesn't matter as they both should have internal extensions first, project realm second and neither adding to project realm
Sat Sep 16 10:25:43 2017  rfscholte:2 is shade plugin (false), can 2 pick up the archiver component from 1?
Sat Sep 16 10:25:47 2017  stephenc:(We have established "pom" order as the final determinatist sort)
Sat Sep 16 10:26:19 2017  stephenc:2 will pick up its own archiver *first* but see the others after
Sat Sep 16 10:26:37 2017  stephenc:Unless 2 is declared with extensions=true
Sat Sep 16 10:27:13 2017  stephenc:If jar and shade both have extensions=true then the winning archiver will come from the pom order
Sat Sep 16 10:27:33 2017  stephenc:And /build/extensions should come *before* plugin extensions
Sat Sep 16 10:27:34 2017  rfscholte:so in the end all extensions from plugins are actually part of the project realm, but it must respect the order!
Sat Sep 16 10:28:04 2017  stephenc:That is how I interpret the current site docs
Sat Sep 16 10:28:20 2017  stephenc:But only when extensions=true
Sat Sep 16 10:28:46 2017  stephenc:When extensions=false, the plugin'S extensions should come first
Sat Sep 16 10:28:59 2017  stephenc:*aha* so it may be a correct fix
Sat Sep 16 10:29:18 2017  stephenc:*if* plugin realm is a child of project realm
Sat Sep 16 10:29:21 2017  rfscholte::) I now start to think so as well
Sat Sep 16 10:29:56 2017  stephenc:Ok, I think I need to confirm with a test or something
Sat Sep 16 10:30:34 2017  stephenc:But if my analysis is core then I am ok with defending 6209 in 3.5.1
Sat Sep 16 10:30:47 2017  stephenc:S/core/correct
Sat Sep 16 10:31:09 2017  rfscholte:yep
Sat Sep 16 10:31:39 2017  stephenc:We'll need some good release notes ;-)
Sat Sep 16 10:31:53 2017  stephenc:"There will be blood"
Sat Sep 16 10:32:32 2017  stephenc:Builds will be broken, because plugins have bugs
Sat Sep 16 10:33:12 2017  rfscholte:or unnecessary extension=true...
Sat Sep 16 10:33:21 2017  stephenc:Yep
Sat Sep 16 10:34:41 2017  rfscholte:some are already pissed off due to the late https://issues.apache.org/jira/browse/MNG-6240 fix ...there was already blood
Sat Sep 16 10:37:07 2017  stephenc:Ugh
Sat Sep 16 10:37:32 2017  stephenc:Yeah, I think the release notes are going to be fun to write up
Sat Sep 16 10:37:48 2017  stephenc:More correctly "great fun"
Sat Sep 16 10:37:56 2017  rfscholte::D
Sat Sep 16 10:38:03 2017  stephenc:"Fun" = a picnic with the family
Sat Sep 16 10:38:39 2017  stephenc:"Great fun" = a picnic with the family, attacked by ants, wasps and chased out of the field by a bull
Sat Sep 16 10:38:49 2017  rfscholte:LOL
Sat Sep 16 10:39:34 2017  stephenc:We went on many picnics I am sure, but the only one we remember is the one my dad told us would be "great fun"
Sat Sep 16 10:40:26 2017  stephenc:This picnic, of legend, is where our family discovered the difference between "fun" and "great fun"
Sat Sep 16 10:41:37 2017  stephenc:There were many fun walks, but the "great fun" walk was the one where my brother ended up with 3 stitches on his forehead and a tetanus shot ;-)
Sat Sep 16 10:42:55 2017  rfscholte:the more blood, the better you'll remember
Sat Sep 16 10:43:19 2017  stephenc:rfscholte: do you have time to take a stab at updating the draft release notes
Sat Sep 16 10:43:49 2017  stephenc:I'm going to see if I can create a theory confirmation test to add to the IT suite
Sat Sep 16 10:44:14 2017  rfscholte:sorry, no. Got some Java9 activities and a JavaOne presentation to complete
Sat Sep 16 10:44:26 2017  stephenc:Then, assuming theory confirmed, I'll tidy up the release notes on Monday and push the release
Sat Sep 16 10:44:38 2017  stephenc:No worries...
Sat Sep 16 10:45:20 2017  stephenc:Will you have availability to review the notes on Monday evening UTC?
Sat Sep 16 10:46:01 2017  rfscholte:I have a meeting, can do it after that, just before midnight
Sat Sep 16 10:46:09 2017  rfscholte:CEST
Sat Sep 16 10:46:26 2017  stephenc:Ok.
Sat Sep 16 10:46:50 2017  stephenc:I'll draft the notes on Monday and close the vote
Sat Sep 16 10:47:06 2017  stephenc:Then I'll push the release on Tuesday
Sat Sep 16 10:47:13 2017  rfscholte:great!
Sat Sep 16 10:48:29 2017  stephenc:Otoh if the theory is wrong...
Sat Sep 16 10:49:38 2017  stephenc:has to wrap up... matches nearly over
Sat Sep 16 14:44:55 2017  khmarbaise:Joined the channel
Sat Sep 16 20:14:22 2017  khmarbaise:Left the channel

Comments