Displaying #traffic-server/2015-10-22.log:

Thu Oct 22 00:36:55 2015  jrushford:Joined the channel
Thu Oct 22 00:38:55 2015  jrushford:Joined the channel
Thu Oct 22 00:43:01 2015  jrushford:Joined the channel
Thu Oct 22 02:28:36 2015  biilmann:Joined the channel
Thu Oct 22 03:29:17 2015  biilmann:Joined the channel
Thu Oct 22 04:01:00 2015  psp:Joined the channel
Thu Oct 22 04:02:21 2015  es:Joined the channel
Thu Oct 22 04:30:06 2015  biilmann:Joined the channel
Thu Oct 22 04:35:15 2015  biilmann:Joined the channel
Thu Oct 22 04:59:11 2015  es:Joined the channel
Thu Oct 22 05:31:04 2015  oag:Joined the channel
Thu Oct 22 05:33:05 2015  oag:Hi, I have a question about threading in traffic server (cppapi but probably no different from the regular plugin api) ..
Thu Oct 22 05:34:33 2015  oag:if in an intercept plugin I make an async http request, is it possible for the response to be delivered on a different thread to the .. umm i guess it’s called handleInputComplete event in the C++ api.
Thu Oct 22 05:51:08 2015  biilmann:Joined the channel
Thu Oct 22 05:56:10 2015  biilmann:Joined the channel
Thu Oct 22 06:01:10 2015  biilmann:Joined the channel
Thu Oct 22 08:18:34 2015  Lethalman:Joined the channel
Thu Oct 22 08:53:01 2015  bahumbug:Joined the channel
Thu Oct 22 09:14:10 2015  oag:Joined the channel
Thu Oct 22 09:38:26 2015  jrickman:Joined the channel
Thu Oct 22 10:22:06 2015  oschaaf:Joined the channel
Thu Oct 22 11:14:10 2015  Besta:Joined the channel
Thu Oct 22 11:14:58 2015  Besta:Morning guys
Thu Oct 22 12:27:09 2015  JSeymour:Joined the channel
Thu Oct 22 12:42:18 2015  bahumbug:Joined the channel
Thu Oct 22 13:10:56 2015  shinrich1:Joined the channel
Thu Oct 22 13:25:01 2015  esproul:Joined the channel
Thu Oct 22 14:00:42 2015  zwoop:morning!
Thu Oct 22 14:22:28 2015  davet_:Joined the channel
Thu Oct 22 14:41:31 2015  dcarlin:zwoop: how does search work on docs.trafficserver.apache.org? it kind of sucks
Thu Oct 22 14:41:46 2015  zwoop:yes, yes it does
Thu Oct 22 14:41:49 2015  dcarlin:example
Thu Oct 22 14:41:58 2015  dcarlin:why doesn't searching for 'consistent' return this page?
Thu Oct 22 14:41:58 2015  dcarlin:https://docs.trafficserver.apache.org/en/latest/reference/configuration/parent.config.en.html
Thu Oct 22 14:42:00 2015  zwoop:it's a read-the-docs feature, I believe they do it inside Javascript
Thu Oct 22 14:42:09 2015  zwoop:because of consistent hashing I'm sure
Thu Oct 22 14:42:15 2015  dcarlin:haha
Thu Oct 22 14:42:27 2015  dcarlin:the word appears by itself on the page
Thu Oct 22 14:42:28 2015  zwoop:(parent.config has support for consistent hashing)
Thu Oct 22 14:42:31 2015  zwoop:right
Thu Oct 22 14:42:47 2015  zwoop:I'm not too thrilled with read-the-docs to be honest :/
Thu Oct 22 14:42:49 2015  dcarlin:its not like the only instance is consistent_hash
Thu Oct 22 14:42:52 2015  dcarlin:ok
Thu Oct 22 14:43:20 2015  zwoop:I tried to setup my own instance of read-the-docs, but it's literally impossible to get it to work
Thu Oct 22 14:44:06 2015  zwoop:one of the big problems with the way RTD works is that it has absolute URLs to a bunch of JS / CSS files, which means, all the efforts we've made for HTTP/2 is more or less ignored
Thu Oct 22 14:44:22 2015  zwoop:if someone is interested, I'd be hugely +1 on getting rid of RTD, and host something ourselves.
Thu Oct 22 14:45:49 2015  dcarlin:my only complaint is search
Thu Oct 22 14:45:57 2015  dcarlin:I can just go 'site:docs.trafficserver.apache.org consistent' in a search engine
Thu Oct 22 15:01:08 2015  ggherdov_:Joined the channel
Thu Oct 22 15:04:14 2015  BlackCob-:Joined the channel
Thu Oct 22 15:07:05 2015  maskit:Joined the channel
Thu Oct 22 15:10:16 2015  zwoop:what I dislike is our lack of control (like I said, I can't get it to fetch static components through our ATS instance)
Thu Oct 22 15:35:15 2015  reveller1:Joined the channel
Thu Oct 22 15:36:16 2015  reveller:Joined the channel
Thu Oct 22 15:52:31 2015  blattj:Joined the channel
Thu Oct 22 15:56:51 2015  blattj:Joined the channel
Thu Oct 22 16:02:11 2015  biilmann:Joined the channel
Thu Oct 22 16:10:34 2015  Becoming_:Joined the channel
Thu Oct 22 16:14:46 2015  gancho:Joined the channel
Thu Oct 22 16:21:22 2015  zwoop:reveller does that include the code as well ?
Thu Oct 22 16:21:36 2015  zwoop:reveller just updating the NOTICE file, without the code, doesn't make a lot of sense :)
Thu Oct 22 17:08:18 2015  blattj:Joined the channel
Thu Oct 22 17:13:45 2015  biilmann:Joined the channel
Thu Oct 22 17:30:07 2015  shinrich2:Joined the channel
Thu Oct 22 17:31:28 2015  Amaryllis:Joined the channel
Thu Oct 22 17:37:15 2015  es:Joined the channel
Thu Oct 22 18:00:07 2015  reveller:Amaryllis: I just submitted a pull request with an updated NOTICE file including a copyright for GoDaddy, and I included the original code updated with clang-format. Can you rebase your patch and resubmit your pull request against that?
Thu Oct 22 18:00:13 2015  psp:Joined the channel
Thu Oct 22 18:30:41 2015  _klk_:Joined the channel
Thu Oct 22 19:06:26 2015  tomr_frnd:Joined the channel
Thu Oct 22 19:34:27 2015  biilmann:Joined the channel
Thu Oct 22 19:34:41 2015  _klk_:Joined the channel
Thu Oct 22 19:40:08 2015  Amaryllis:reveller: i haven't made a PR yet, but i'll rebase against master before i do
Thu Oct 22 19:40:23 2015  Amaryllis:i wanted to convert the readme to actual documentation first
Thu Oct 22 19:41:44 2015  Amaryllis:i actually reformatted the code on our local branch, so maybe i'll just redo the change
Thu Oct 22 19:42:13 2015  Amaryllis:(https://github.com/torchbox/trafficserver/blob/6.0T/plugins/experimental/cache_key_genid/cache_key_genid.c)
Thu Oct 22 20:04:16 2015  _klk_:Joined the channel
Thu Oct 22 20:06:06 2015  dynek:Joined the channel
Thu Oct 22 20:29:00 2015  Amaryllis:i'm going to write a plugin for our use that normalises URL query parameters - sorts them alphabetically and removes 'unapproved' ones
Thu Oct 22 20:29:11 2015  Amaryllis:does that seem useful enough that i should submit a PR to integrate it?
Thu Oct 22 20:29:19 2015  Amaryllis:(we have at least 2 real-world use cases)
Thu Oct 22 21:09:33 2015  mturk__:Joined the channel
Thu Oct 22 21:22:05 2015  bcall:zwoop: weren't you working on something like what Amaryllis is talking about?
Thu Oct 22 21:22:47 2015  zwoop:bcall yeah, gancho has that already done
Thu Oct 22 21:22:52 2015  zwoop:he's presenting it at the summit
Thu Oct 22 21:23:00 2015  bcall:it that in our tree now?
Thu Oct 22 21:23:06 2015  zwoop:bcall not yet
Thu Oct 22 21:23:15 2015  bcall:waiting on legal?
Thu Oct 22 21:23:21 2015  bcall::)
Thu Oct 22 21:23:30 2015  Amaryllis:any ETA?
Thu Oct 22 21:31:29 2015  _klk_:Joined the channel
Thu Oct 22 21:35:33 2015  bcall:zwoop: crazy swedes - Man in 'Star Wars' mask attacks Swedish school with sword - http://goo.gl/7H46dc
Thu Oct 22 21:37:19 2015  gancho:Amaryllis: unfortunately no ETA but has been in legal for a while, hope to get it out soon
Thu Oct 22 21:39:30 2015  Amaryllis:okay. i may start on our version anyway, since it isn't too complicated :)
Thu Oct 22 21:45:00 2015  jpeach:zwoop: is that based on the shasta plugin?
Thu Oct 22 21:45:00 2015  oag:Joined the channel
Thu Oct 22 21:46:22 2015  gancho:jpeach: yes
Thu Oct 22 21:46:30 2015  jpeach:gotcha
Thu Oct 22 21:59:52 2015  _klk_:Joined the channel
Thu Oct 22 22:06:51 2015  zwoop:jpeach it merges the concept of several of those plugins all into one
Thu Oct 22 22:06:58 2015  zwoop:jpeach but yes, it's all your fault ;)
Thu Oct 22 22:07:24 2015  gancho_:Joined the channel
Thu Oct 22 22:08:08 2015  jpeach:normalizing query parameters seems useful in core
Thu Oct 22 22:08:21 2015  jpeach:though of course header_rewrite could do it
Thu Oct 22 22:08:56 2015  zwoop:lol
Thu Oct 22 22:09:17 2015  jpeach:you should add a lua-eval operator to header_rewrite
Thu Oct 22 22:10:36 2015  zwoop:hmmm
Thu Oct 22 22:10:44 2015  zwoop:yeah, you should!
Thu Oct 22 22:11:04 2015  jpeach:lol
Thu Oct 22 22:24:10 2015  jrickman:Joined the channel
Thu Oct 22 22:28:52 2015  bahumbug:Joined the channel
Thu Oct 22 22:40:26 2015  _klk_:Joined the channel
Thu Oct 22 22:43:04 2015  gancho_:header_rewrite is a magical fix-all tool :)
Thu Oct 22 22:46:18 2015  gancho_:are we going to add geo-location there ?
Thu Oct 22 22:58:45 2015  _klk_:Joined the channel
Thu Oct 22 23:01:52 2015  _klk_:Joined the channel
Thu Oct 22 23:03:39 2015  Amaryllis:https://github.com/torchbox/trafficserver/blob/6.0T/plugins/experimental/query_normalize/query_normalize.c
Thu Oct 22 23:03:53 2015  Amaryllis:obviously, completely untested (except that it seems to work in my dev environment)
Thu Oct 22 23:05:14 2015  Amaryllis:(example usage: https://dpaste.de/H0uz)
Thu Oct 22 23:36:39 2015  zwoop:Amaryllis what does it actually do? :)
Thu Oct 22 23:40:35 2015  Amaryllis:zwoop: https://dpaste.de/fUMB
Thu Oct 22 23:40:47 2015  zwoop:ah
Thu Oct 22 23:41:08 2015  sudheerv:Amaryllis: you are felicity as well?
Thu Oct 22 23:41:09 2015  zwoop:like Varnish's url-sort
Thu Oct 22 23:41:10 2015  zwoop:https://www.varnish-cache.org/vmod/url-sort
Thu Oct 22 23:41:13 2015  Amaryllis:sudheerv: yes
Thu Oct 22 23:41:18 2015  zwoop:lol, ah
Thu Oct 22 23:41:20 2015  sudheerv::) you have many names :)
Thu Oct 22 23:41:21 2015  zwoop:that explains a lot
Thu Oct 22 23:41:24 2015  sudheerv:lol
Thu Oct 22 23:41:26 2015  Amaryllis:sorry ;)
Thu Oct 22 23:41:31 2015  sudheerv:np..
Thu Oct 22 23:41:33 2015  sudheerv::)
Thu Oct 22 23:41:44 2015  zwoop:there's a saying in swedish (if I translate), something like "A loved child has many names"
Thu Oct 22 23:42:04 2015  sudheerv:lol
Thu Oct 22 23:42:13 2015  zwoop:Amaryllis ok, that's cool. You should work with Gancho to incorporate this into his plugin
Thu Oct 22 23:42:16 2015  sudheerv:Amaryllis: but, we have other ways of stripping query params in the cahce key though
Thu Oct 22 23:42:22 2015  sudheerv:cacheurl plugin, regex_remap etc
Thu Oct 22 23:42:28 2015  zwoop:Amaryllis the goal is to have one plugin that can do a lot, because, you can't chaing cahce key manipulating plugins.
Thu Oct 22 23:42:39 2015  zwoop:sudheerv this doesn't strip them, it sorts them
Thu Oct 22 23:42:43 2015  zwoop:I assume :)
Thu Oct 22 23:42:46 2015  Amaryllis:this one does both
Thu Oct 22 23:42:54 2015  sudheerv:umm…ok - reading more..
Thu Oct 22 23:43:01 2015  Amaryllis:sudheerv: doing it with regexp is really ugly, though.
Thu Oct 22 23:43:17 2015  zwoop:such that http://example.com/?foo=bar&fie=fum is the same cache key as http://example.com/?fie=fum&foo=bar
Thu Oct 22 23:43:30 2015  zwoop:sudheerv see https://www.varnish-cache.org/vmod/url-sort
Thu Oct 22 23:43:31 2015  sudheerv:interesting..
Thu Oct 22 23:43:32 2015  Amaryllis:zwoop: doesn't gancho's plugin already do this?
Thu Oct 22 23:43:39 2015  sudheerv:but, how's that different to stripping?
Thu Oct 22 23:43:41 2015  zwoop:Amaryllis I don't know :) Maybe it does.
Thu Oct 22 23:43:52 2015  zwoop:I still owe gancho_ a review on that too
Thu Oct 22 23:43:54 2015  sudheerv:ok, may be, in some cases it'd be different indeed
Thu Oct 22 23:44:11 2015  Amaryllis:sudheerv: you have two parameters, 'limit' and 'sort'. you don't want to strip either, but you want ?limit=10&sort=desc to have the same cache key as ?sort=desc&limit=10
Thu Oct 22 23:44:18 2015  sudheerv:i.e. if you still want to keep the query params and dont care about the order?
Thu Oct 22 23:44:18 2015  Amaryllis:sudheerv: so you have to sort them
Thu Oct 22 23:44:23 2015  sudheerv:yeah, got it
Thu Oct 22 23:45:04 2015  Amaryllis:i wrote this to fix a very specific problem on a client site, so if there's another plugin to do it already, that's fine :)
Thu Oct 22 23:45:09 2015  jpeach:I have always kinda liked the idea of single-purpose plugins that you can compose in useful ways, but it does lead to more configuration complexity
Thu Oct 22 23:45:20 2015  sudheerv:Amaryllis: cool, but, regex remap has a simple way of doing the strip part atleast
Thu Oct 22 23:45:27 2015  sudheerv:@pparam=no-query-string, i think
Thu Oct 22 23:45:32 2015  zwoop:jpeach agreed. Hence those ideas around "lua" instead.
Thu Oct 22 23:45:41 2015  Amaryllis:sudheerv: that sounds like it strips the entire query string? i want to keep some of it
Thu Oct 22 23:45:58 2015  sudheerv:yeah,agree - it doesnt give you a lot of flexibility
Thu Oct 22 23:46:09 2015  sudheerv:but, perhaps, your plugin can be incorporated into regex remap?
Thu Oct 22 23:46:15 2015  zwoop:jpeach cache key manipulation is particularly difficult to avoid a monolithic plugin, because you can't (easily at least?) chain two or more plugins to modify the cache key.
Thu Oct 22 23:46:19 2015  Amaryllis:it doesn't use regexps and it's not a remap plugin
Thu Oct 22 23:46:23 2015  Amaryllis:so i don't think that would be appropriate :P
Thu Oct 22 23:46:31 2015  sudheerv:agree with what zwoop said
Thu Oct 22 23:46:52 2015  Amaryllis:(actually, it will be a remap plugin once i write the code, but still... it seems unrelated to what regexp-remap does)
Thu Oct 22 23:47:03 2015  sudheerv:Amaryllis: hmm, ok - but, there's cacheurl as well
Thu Oct 22 23:47:11 2015  jpeach:yeh, a lot of the problem with chaining plugins in nice ways is filtering on the transaction to figure out whether to apply the plugin action
Thu Oct 22 23:50:00 2015  jpeach:I don't see how that varnish url-sort plugin is O(n log(n) ... seems basically linear complexity to me
Thu Oct 22 23:51:29 2015  jpeach:hey bcall?
Thu Oct 22 23:59:02 2015  gancho_:sundheerv, jpeach, zwoop: I already added --remove-all-params to cachekey_norm
Thu Oct 22 23:59:16 2015  gancho_:@pparam=--remove-all-params
Thu Oct 22 23:59:17 2015  zwoop:gancho_ cool. We should consider the sort feature too
Thu Oct 22 23:59:42 2015  jpeach:can you think of a better name than cachekey_norm?
Thu Oct 22 23:59:52 2015  zwoop:no :)
Thu Oct 22 23:59:54 2015  gancho_:also added @pparam=--sort-params

Comments