Displaying #traffic-server/2015-12-03.log:

Thu Dec 3 00:01:19 2015  _klk_:Joined the channel
Thu Dec 3 00:07:23 2015  biilmann:Joined the channel
Thu Dec 3 00:11:15 2015  reveller1:Joined the channel
Thu Dec 3 00:32:56 2015  zwoop:bcall so what did we decide, to just mark it with one Fix Version within each major version ?
Thu Dec 3 00:33:19 2015  zwoop:so, 5.3.3, 6.0.1, but not 5.3.3, 6.0.1, 6.1.0
Thu Dec 3 00:44:38 2015  zwoop:bcall we didn't cherry pick the fixes for madvise ?
Thu Dec 3 00:44:49 2015  zwoop:something isn't merging properly for me for 6.0.1 :/
Thu Dec 3 00:47:53 2015  zwoop:http://pastebin.com/M4VXVGi0
Thu Dec 3 00:51:34 2015  zwoop:bcall I had previously cherry picked things as PSUdaemon dictated :/
Thu Dec 3 01:06:26 2015  bcall:zwoop: yes, I have the madvise fix in there
Thu Dec 3 01:06:32 2015  bcall:not the extra features
Thu Dec 3 01:07:58 2015  bcall:the list in the bug would have brought in 2 or 3 other features
Thu Dec 3 01:31:41 2015  reveller2:Joined the channel
Thu Dec 3 01:41:28 2015  _klk_:Joined the channel
Thu Dec 3 01:43:08 2015  reveller1:Joined the channel
Thu Dec 3 01:44:39 2015  reveller:Joined the channel
Thu Dec 3 01:45:19 2015  ibrezac:Joined the channel
Thu Dec 3 01:55:26 2015  reveller1:Joined the channel
Thu Dec 3 02:00:40 2015  reveller2:Joined the channel
Thu Dec 3 02:05:34 2015  jjr:Joined the channel
Thu Dec 3 02:18:00 2015  reveller1:Joined the channel
Thu Dec 3 02:25:23 2015  zwoop:bcall gotcha
Thu Dec 3 02:25:26 2015  zwoop:I'll figure it out :)
Thu Dec 3 02:30:13 2015  reveller:Joined the channel
Thu Dec 3 02:46:00 2015  _klk_1:Joined the channel
Thu Dec 3 03:09:45 2015  briang:zwoop, when are you targeting a release of 6.1?
Thu Dec 3 03:10:03 2015  zwoop:Mid January
Thu Dec 3 03:13:09 2015  _klk_:Joined the channel
Thu Dec 3 03:53:28 2015  masaori-:Joined the channel
Thu Dec 3 03:54:41 2015  ibrezac:Joined the channel
Thu Dec 3 03:55:23 2015  phibs:Joined the channel
Thu Dec 3 03:58:59 2015  ibrezac1:Joined the channel
Thu Dec 3 04:32:51 2015  _klk_:Joined the channel
Thu Dec 3 04:54:22 2015  _klk_:Joined the channel
Thu Dec 3 05:03:28 2015  biilmann:Joined the channel
Thu Dec 3 05:50:05 2015  masaori:Joined the channel
Thu Dec 3 05:50:17 2015  masaori_:Left the channel
Thu Dec 3 06:18:14 2015  biilmann:Joined the channel
Thu Dec 3 06:43:04 2015  biilmann:Joined the channel
Thu Dec 3 06:52:02 2015  jrickman:Joined the channel
Thu Dec 3 06:52:17 2015  dstates:Joined the channel
Thu Dec 3 07:18:00 2015  _klk_:Joined the channel
Thu Dec 3 07:22:59 2015  mturk:Joined the channel
Thu Dec 3 08:03:02 2015  _klk_:Joined the channel
Thu Dec 3 08:32:17 2015  phibs:Joined the channel
Thu Dec 3 08:33:14 2015  phibs:Joined the channel
Thu Dec 3 08:36:28 2015  lrea:Joined the channel
Thu Dec 3 09:22:30 2015  Lethalman:Joined the channel
Thu Dec 3 09:35:06 2015  Lethalman:hello
Thu Dec 3 09:35:16 2015  Lethalman:what do I lose if I run traffic_server directly without cop/manager?
Thu Dec 3 09:35:36 2015  Lethalman:heartbeat and config backup? something else?
Thu Dec 3 09:41:54 2015  Lethalman:is it normal that this page is empty? https://docs.trafficserver.apache.org/en/latest/admin-guide/interaction/index.en.html
Thu Dec 3 09:46:53 2015  Lethalman:oh I lose all the management via traffic_line and traffic_top...
Thu Dec 3 12:20:01 2015  niq:Joined the channel
Thu Dec 3 12:49:31 2015  mturk:Joined the channel
Thu Dec 3 12:49:32 2015  mturk:Joined the channel
Thu Dec 3 13:01:43 2015  niq:Joined the channel
Thu Dec 3 13:01:55 2015  niq:Joined the channel
Thu Dec 3 13:29:22 2015  felicity:Lethalman: why would you do that, out of interest?
Thu Dec 3 13:29:33 2015  blattj:Joined the channel
Thu Dec 3 13:29:45 2015  Lethalman:felicity, because under heavy load the cop is not able to heartbeat and restarts TS
Thu Dec 3 13:29:50 2015  Lethalman:I've filed an issue about that
Thu Dec 3 13:30:15 2015  Lethalman:so I have systemd which restarts automatically TS if it crashes or whatelse
Thu Dec 3 13:30:24 2015  felicity:hm, interesting
Thu Dec 3 13:30:33 2015  Lethalman:and haproxy that takes it out of the cluster if it doesn't heartbeat
Thu Dec 3 13:30:45 2015  Lethalman:I don't want TS to be restarted just because it doesn't respond in time to an heartbeat
Thu Dec 3 13:31:08 2015  Lethalman:but I'm happy I can start traffic_manager directly
Thu Dec 3 13:31:22 2015  Lethalman:bypassing traffic_cop, that's all I needed
Thu Dec 3 13:57:10 2015  biilmann:Joined the channel
Thu Dec 3 13:59:48 2015  mturk:Joined the channel
Thu Dec 3 13:59:49 2015  mturk:Joined the channel
Thu Dec 3 14:02:43 2015  blattj:Joined the channel
Thu Dec 3 14:03:43 2015  niq:Joined the channel
Thu Dec 3 14:22:29 2015  ibrezac:Joined the channel
Thu Dec 3 14:24:15 2015  swoc:Joined the channel
Thu Dec 3 14:30:43 2015  davet_:Joined the channel
Thu Dec 3 14:33:51 2015  shinrich1:Joined the channel
Thu Dec 3 14:40:28 2015  shinrich1:Can you bring in a laser pointer when you come in?
Thu Dec 3 14:45:16 2015  yamc:Joined the channel
Thu Dec 3 15:01:02 2015  zwoop:Lethalman you can run manager + server
Thu Dec 3 15:02:20 2015  zwoop:shinrich1 Lethalman also, I've seen some times that cop can fail under very heavy load, but that seems more like a bug. I mean, it clearly should not take 10 seconds to serve such a simple request. And maybe it should give priority to those requests anyways.
Thu Dec 3 15:03:29 2015  shinrich1:Oops wrong window..
Thu Dec 3 15:04:11 2015  jrushford:Joined the channel
Thu Dec 3 15:10:58 2015  zwoop:shinrich1 he should still bring a laser pointer IMO
Thu Dec 3 15:11:08 2015  zwoop:if he's not in this channel, he's doing it wrong
Thu Dec 3 15:11:11 2015  zwoop:or she
Thu Dec 3 15:12:05 2015  zwoop:bcall briang PSUdaemon for a patch like http://pastebin.com/eTwhxUL0, do we still go through Github PR? I understand the importance of process, but it seems silly and much to rigid for something like that to be PRd.
Thu Dec 3 15:12:11 2015  shinrich1:zwoop: Anyone is welcome to stop by and bring me a laser pointer :-)
Thu Dec 3 15:12:26 2015  zwoop:lol
Thu Dec 3 15:15:22 2015  zwoop:sudheerv can you look at http://pastebin.com/666L9kAB, and tell my, why do we get the TXN twice?
Thu Dec 3 15:15:36 2015  zwoop:TXN client headers ....
Thu Dec 3 15:23:33 2015  PSUdaemon:zwoop: meh. could be argued that is on the level of docs...
Thu Dec 3 15:23:35 2015  PSUdaemon:i dunno
Thu Dec 3 15:23:43 2015  zwoop:yeah, I don't know either
Thu Dec 3 15:23:55 2015  zwoop:I'd like us to have the power / flexibility to use reasonable judgement, as committers.
Thu Dec 3 15:24:10 2015  zwoop:I'd still file a Jira for it of course
Thu Dec 3 15:24:28 2015  zwoop:but, I really need that Debug to easily verify that this (newish) directive is doing what I think it does
Thu Dec 3 15:28:53 2015  Lethalman:zwoop, yep I just run traffic_manager and it's fine
Thu Dec 3 15:29:59 2015  zwoop:cool
Thu Dec 3 15:30:05 2015  zwoop:we should still fix this ...
Thu Dec 3 15:36:09 2015  zwoop:shinrich1 don't forget to change the Fix Version on those Jira's as well. And thanks for being the only one who reads my emails! :-) (Now go kick amc into action)
Thu Dec 3 15:37:09 2015  PSUdaemon:whoa, you send emails?!
Thu Dec 3 15:38:40 2015  zwoop:yeah, who knew ?
Thu Dec 3 15:39:05 2015  PSUdaemon:i guess i must be filtering you to spam
Thu Dec 3 15:42:14 2015  shinrich1:zwoop: will do
Thu Dec 3 16:00:56 2015  yamc:I tried to look at zwoop pastebins but they're gone.
Thu Dec 3 16:05:40 2015  zwoop:huh
Thu Dec 3 16:05:50 2015  zwoop:http://pastebin.com/eTwhxUL0
Thu Dec 3 16:05:56 2015  zwoop:it's a trivial patch
Thu Dec 3 16:06:14 2015  zwoop:so the question / issue is, do we use our judgement on things like this, or is the PR process rigid?
Thu Dec 3 16:06:31 2015  zwoop:It is a code change, so doesn't fall under the "no PR required for docs" changes.
Thu Dec 3 16:06:56 2015  yamc:I think we let zwoop use his judgement, everyone else has to PR.
Thu Dec 3 16:07:11 2015  zwoop:oooo
Thu Dec 3 16:07:47 2015  yamc:Also, you can merge your own PR, although I suppose that's a bit of work for a one line change.
Thu Dec 3 16:07:58 2015  zwoop:yeah
Thu Dec 3 16:08:16 2015  zwoop:seems silly to me, and as important as process is, too much process is a burden
Thu Dec 3 16:08:40 2015  felicity:is there a ticket for it?
Thu Dec 3 16:08:45 2015  yamc:The problem is knowing if that one line change matters. E.g., adding one line to the list of WKS strings breaks cache, for instance.
Thu Dec 3 16:08:47 2015  zwoop:felicity not yet
Thu Dec 3 16:08:55 2015  zwoop:yamc right
Thu Dec 3 16:09:41 2015  yamc:Even a debug line might call some method/function that breaks stuff.
Thu Dec 3 16:09:48 2015  yamc:I'm OK with judgement, though.
Thu Dec 3 16:10:04 2015  yamc:Although with some guidelines like "if it's more than one file, must be a PR".
Thu Dec 3 16:10:07 2015  felicity:maybe you could compromise for a change like that and just ask another developer without a PR
Thu Dec 3 16:10:27 2015  yamc:Hmmmm, yes, that could work. That's really just an informal PR.
Thu Dec 3 16:10:31 2015  felicity:then again, i have to do PRs for one-line TSDebug changes, so it's only fair you should too :-P
Thu Dec 3 16:10:32 2015  zwoop:I'm sure once in a while (hopefully rarely) someone will make a bad judgement call, but that's one of those things where the risk is worth it.
Thu Dec 3 16:11:06 2015  zwoop:felicity Aha, see, there's your incentive to become a committer!
Thu Dec 3 16:11:14 2015  zwoop:you get that extra special power
Thu Dec 3 16:11:50 2015  zwoop:and yeah, I'd be fine with that too, just pastebin it here and ask yamc
Thu Dec 3 16:11:54 2015  yamc:The important thing is that everyone switch over to the new Y! "Iris" messanger.
Thu Dec 3 16:12:05 2015  zwoop:yamc does it run on OSX ?
Thu Dec 3 16:12:17 2015  yamc:It has a web interface. Otherwise I don't know.
Thu Dec 3 16:12:27 2015  zwoop:meh
Thu Dec 3 16:12:29 2015  yamc:It has some app variants too.
Thu Dec 3 16:13:05 2015  zwoop:Y! IM has done something odd as of lately, where once in a while, the recommended OSX client (Messages) is unable to deliver messages to your servers. It's quite annoying (so annoying, I switch to AOL AIM)
Thu Dec 3 16:13:14 2015  felicity:zwoop: i'd not considered that actually, but i don't think the few changes i submit really justify it
Thu Dec 3 16:13:44 2015  zwoop:the PR from non-committers has another important purpose too, it makes it a lot easier for the committer(s) to merge it into upstream.
Thu Dec 3 16:13:56 2015  yamc:WAY easier.
Thu Dec 3 16:26:38 2015  niq:Joined the channel
Thu Dec 3 16:27:26 2015  niq:Joined the channel
Thu Dec 3 16:29:35 2015  reveller:Joined the channel
Thu Dec 3 16:33:46 2015  blattj:Joined the channel
Thu Dec 3 16:35:35 2015  blattj1:Joined the channel
Thu Dec 3 16:58:20 2015  PSUdaemon:bcall: ping
Thu Dec 3 17:31:16 2015  shinrich1:Joined the channel
Thu Dec 3 17:44:04 2015  biilmann:Joined the channel
Thu Dec 3 18:00:13 2015  bcall:PSUdaemon: hey
Thu Dec 3 18:00:37 2015  PSUdaemon:hey
Thu Dec 3 18:00:46 2015  PSUdaemon:that KA LRU stuff you added to 5.3
Thu Dec 3 18:00:53 2015  PSUdaemon:supercedes the throttling stuff
Thu Dec 3 18:00:59 2015  PSUdaemon:but the throttling stuff is still active?
Thu Dec 3 18:01:28 2015  bcall:yes
Thu Dec 3 18:01:49 2015  bcall:I would like more testing on the queues and then we can remove throttling
Thu Dec 3 18:02:32 2015  PSUdaemon:is there a preferred mode of operation?
Thu Dec 3 18:02:37 2015  PSUdaemon:like i set the throttling really high?
Thu Dec 3 18:02:43 2015  PSUdaemon:so that the LRU kicks in first?
Thu Dec 3 18:02:46 2015  bcall:yes
Thu Dec 3 18:02:51 2015  PSUdaemon:ok
Thu Dec 3 18:06:46 2015  PSUdaemon:thx
Thu Dec 3 18:30:34 2015  dxu:Joined the channel
Thu Dec 3 18:45:23 2015  zwoop:bcall the multiplexer plugin is not in 6.0.1, right ?
Thu Dec 3 18:45:26 2015  zwoop:TS-4052
Thu Dec 3 18:45:37 2015  zwoop:I get build warnings from the multiplexer plugin due to auto_ptr
Thu Dec 3 18:45:46 2015  bcall:zwoop: yeah, it is not in 6.0.1
Thu Dec 3 18:45:55 2015  zwoop:ok, cool
Thu Dec 3 18:46:34 2015  es:Joined the channel
Thu Dec 3 18:49:29 2015  swoc:Joined the channel
Thu Dec 3 18:50:31 2015  swoc:We really only require gcc 4.3? Really?
Thu Dec 3 18:56:02 2015  shinrich2:Joined the channel
Thu Dec 3 19:17:15 2015  zwoop:jpeach swoc did we really intend for these startup notes etc. to include all the verbose code references? http://pastebin.com/PEZnyTp0
Thu Dec 3 19:17:29 2015  zwoop:swoc 4.4 I think (whatever is in RHEL5)
Thu Dec 3 19:19:55 2015  jpeach:zwoop: do you mean "Be aware that access control checks for HTTP/2 connections are not active!" ?
Thu Dec 3 19:20:05 2015  zwoop:well, all of them
Thu Dec 3 19:20:34 2015  zwoop:I'm ok with the verbosity on Debug, but it seems very excessive to include all that code refernce on all Note etc.
Thu Dec 3 19:20:50 2015  zwoop:it caught me by surprise, and thought we had a crasher / code problem first
Thu Dec 3 19:20:56 2015  jpeach:do you mean the location "<Plugin.cc:84 (plugin_load)>" ?
Thu Dec 3 19:21:02 2015  zwoop:Yes
Thu Dec 3 19:21:08 2015  jpeach:there's a diags setting
Thu Dec 3 19:21:11 2015  zwoop:right
Thu Dec 3 19:21:16 2015  zwoop:we changed the default
Thu Dec 3 19:22:06 2015  zwoop:00b697d8
Thu Dec 3 19:22:21 2015  zwoop:now that I see what this actually does, I'm not sure this is all that awesome :)
Thu Dec 3 19:22:38 2015  zwoop:for normal users, seeing all that is confusing IMO
Thu Dec 3 19:23:33 2015  jpeach:yeh I flipped the default because otherwise the messages tend to be useless, but it is mainly useful for debugging
Thu Dec 3 19:23:39 2015  jpeach:I don't mind much if you revert
Thu Dec 3 19:25:01 2015  jpeach:would be nice to have it just on DEBUG levels
Thu Dec 3 19:29:16 2015  biilmann:Joined the channel
Thu Dec 3 19:29:52 2015  zwoop:I think it'd be nice if that only applies to Debug
Thu Dec 3 19:29:56 2015  zwoop:they are definitely useful there
Thu Dec 3 19:30:19 2015  zwoop:I'll file a Jira on it
Thu Dec 3 19:39:45 2015  zwoop:bcall the 6.0.x buildbots were hanging due to OSX (the bot is down), I've kicked it such that all other builds should kick off now (so we can verify all those builds for 6.0.1 release candidate)
Thu Dec 3 19:41:40 2015  bcall:zwoop: just osx?
Thu Dec 3 19:42:00 2015  zwoop:yeah, I've asked Barrow to reboot the box :)
Thu Dec 3 19:42:09 2015  zwoop:but, when it hangs like that, it holds up other builds from finishing
Thu Dec 3 19:42:19 2015  zwoop:so all 6.0.x builds are running again now
Thu Dec 3 19:42:26 2015  zwoop:https://ci.trafficserver.apache.org/view/6.0.x/
Thu Dec 3 19:42:45 2015  bcall:k, cool
Thu Dec 3 19:42:46 2015  bcall:thx
Thu Dec 3 19:44:36 2015  zwoop:bcall RAT looks good for 6.0.1 as well (https://ci.trafficserver.apache.org/files/RAT/rat-6.0.x.txt)
Thu Dec 3 19:46:34 2015  blattj:Joined the channel
Thu Dec 3 19:46:36 2015  _klk_:Joined the channel
Thu Dec 3 19:51:50 2015  swoc:zwoop - I don't know why all those notes show up. It's handy in one sense to know something is actually firing up.
Thu Dec 3 19:52:06 2015  zwoop:right
Thu Dec 3 19:52:09 2015  zwoop:they have always been there
Thu Dec 3 19:52:14 2015  zwoop:they just look "scary" now :)
Thu Dec 3 19:52:44 2015  swoc:So put smiley faces in them?
Thu Dec 3 19:52:49 2015  zwoop:hah
Thu Dec 3 19:53:01 2015  swoc:Our documentation claims we only rquire gcc 4.3. Should that get updated?
Thu Dec 3 19:54:20 2015  swoc:I'm looking at that auto_ptr thing you assigned me - best bet is use a tr1 scoped_ptr or equivalent.
Thu Dec 3 19:54:49 2015  swoc:It's in a plugin so we just --c++0xx as for CPP API and then tr1::scoped_ptr
Thu Dec 3 19:55:36 2015  swoc:Also, any thoughts on the session hook thing I sent to the dev list?
Thu Dec 3 19:56:56 2015  swoc:Ah, I see what you mean - the source file and line #. Hmmm. I don't see a reason to ahve them other than
Thu Dec 3 19:57:14 2015  swoc:it might be a non-trivial amount of work to not have them there and have them when they're useful.
Thu Dec 3 19:59:06 2015  ibrezac:Joined the channel
Thu Dec 3 20:01:29 2015  swoc:offline for a bit, back in a while.
Thu Dec 3 20:01:38 2015  zwoop:swoc we bumped it to RHEL6 didn't we ?
Thu Dec 3 20:02:33 2015  zwoop:swoc Yes, we should update the docs:
Thu Dec 3 20:02:34 2015  zwoop:gcc version 4.4.7 20120313 (Red Hat 4.4.7-16) (GCC)
Thu Dec 3 20:02:36 2015  zwoop:that's what we require
Thu Dec 3 20:07:50 2015  igalic:maybe this documentation should mention that traffic_line needs traffic_manager to be running https://trafficserver.readthedocs.org/en/latest/appendices/command-line/traffic_line.en.html
Thu Dec 3 20:08:26 2015  zwoop:igalic make it so #1
Thu Dec 3 20:08:47 2015  igalic:zwoop: but then again, traffic_line is deprecated, and that's not mentioned in that thing either.
Thu Dec 3 20:09:05 2015  zwoop:is it mentioned for the traffic_ctl docs ?
Thu Dec 3 20:12:34 2015  igalic:zwoop: nope
Thu Dec 3 20:14:29 2015  blattj:Joined the channel
Thu Dec 3 20:16:20 2015  swoc:Joined the channel
Thu Dec 3 20:19:36 2015  PSUdaemon:swoc: you are seeing these errors on f23?
Thu Dec 3 20:19:59 2015  PSUdaemon:or was that zwoop?
Thu Dec 3 20:20:15 2015  swoc:The auto_ptr errors? I see them on FC22.
Thu Dec 3 20:20:22 2015  PSUdaemon:FC?
Thu Dec 3 20:20:26 2015  PSUdaemon:there is no FC 22 :)
Thu Dec 3 20:20:31 2015  swoc:Fedora Core
Thu Dec 3 20:20:42 2015  PSUdaemon:they dropped the "Core" a while back
Thu Dec 3 20:20:45 2015  PSUdaemon::-p
Thu Dec 3 20:21:06 2015  swoc:They can change the name but they can't change me. Just like "Lie-nux".
Thu Dec 3 20:21:18 2015  PSUdaemon:https://fedoraproject.org/wiki/Core
Thu Dec 3 20:21:30 2015  PSUdaemon:"Please do not refer to Fedora as "Fedora Core" anymore."
Thu Dec 3 20:21:33 2015  PSUdaemon:they even asked nicely!
Thu Dec 3 20:21:57 2015  swoc:You ask me stuff nicely all the time, how does that work out for you :-)?
Thu Dec 3 20:22:22 2015  swoc:I need to get my ZNC fixed at some point.
Thu Dec 3 20:23:38 2015  PSUdaemon:so all of a sudden my builds are bombing too
Thu Dec 3 20:23:51 2015  PSUdaemon:and this is on an internal branch in stuff that hasn't been touched in a long time
Thu Dec 3 20:23:56 2015  PSUdaemon:and i think it was my upgrade
Thu Dec 3 20:28:06 2015  swoc:You got upgraded? More hair or better abs?
Thu Dec 3 20:28:28 2015  shinrich2:whiter teeth?
Thu Dec 3 20:29:05 2015  zwoop:PSUdaemon CentOS7
Thu Dec 3 21:37:56 2015  ibrezac:Joined the channel
Thu Dec 3 21:51:25 2015  reveller:bcall: ping
Thu Dec 3 21:54:25 2015  reveller:bcall: I've build 6.0.1-rc0 on CentOS6 and ran the regression tests, and all passed. I will run some load tests on it either tomorrow or early next week and let you know.
Thu Dec 3 21:56:46 2015  _klk_:Joined the channel
Thu Dec 3 21:58:03 2015  esproul:Joined the channel
Thu Dec 3 22:01:34 2015  bcall:reveller: cool, the vote closes on Saturday
Thu Dec 3 22:12:43 2015  ibrezac:Joined the channel
Thu Dec 3 22:40:03 2015  biilmann:Joined the channel
Thu Dec 3 22:48:13 2015  biilmann:Joined the channel
Thu Dec 3 22:53:13 2015  biilmann:Joined the channel
Thu Dec 3 23:12:44 2015  _klk_:Joined the channel
Thu Dec 3 23:17:29 2015  biilmann:Joined the channel
Thu Dec 3 23:38:32 2015  niq:Joined the channel
Thu Dec 3 23:45:16 2015  zwoop:wonder if we should have these ASFBot messages go to traffic-server-ci or some other channel? If we start using Github more rigorously, this will become tedious
Thu Dec 3 23:45:21 2015  zwoop:Humbedooh amc jpeach ^
Thu Dec 3 23:58:00 2015  briang:zwoop, regarding your PR for that patch
Thu Dec 3 23:58:07 2015  briang:I would not create a ticket or a pr for that
Thu Dec 3 23:58:12 2015  briang:juts seems extereme
Thu Dec 3 23:58:22 2015  briang:committers should have enough freedom IMO to do simple things like that
Thu Dec 3 23:58:35 2015  briang:or changing: int i; to int i = 0;
Thu Dec 3 23:58:42 2015  zwoop:ok :)
Thu Dec 3 23:58:44 2015  briang:also trivial changes like that we shouldn't require it

Comments