Displaying #traffic-server/2016-01-04.log:

Mon Jan 4 00:04:50 2016  masaori__:Joined the channel
Mon Jan 4 00:59:34 2016  biilmann:Joined the channel
Mon Jan 4 01:25:19 2016  biilmann:Joined the channel
Mon Jan 4 03:47:04 2016  psp:Joined the channel
Mon Jan 4 04:03:11 2016  es:Joined the channel
Mon Jan 4 05:20:50 2016  psp1:Joined the channel
Mon Jan 4 05:26:18 2016  psp:Joined the channel
Mon Jan 4 08:32:40 2016  masaori__:Joined the channel
Mon Jan 4 09:36:09 2016  felicity:TS-4009
Mon Jan 4 09:36:26 2016  felicity:i don't think this patch is correct, it creates the mutex always in fetch_resource() but doesn't always use it, so it'll leak mutexes
Mon Jan 4 09:58:04 2016  sommarnatt:Joined the channel
Mon Jan 4 10:32:03 2016  biilmann:Joined the channel
Mon Jan 4 11:33:05 2016  biilmann:Joined the channel
Mon Jan 4 11:49:20 2016  JSeymour:Joined the channel
Mon Jan 4 12:33:33 2016  biilmann:Joined the channel
Mon Jan 4 13:34:23 2016  biilmann:Joined the channel
Mon Jan 4 13:36:09 2016  niq:Joined the channel
Mon Jan 4 14:35:03 2016  biilmann:Joined the channel
Mon Jan 4 14:36:16 2016  shinrich1:Joined the channel
Mon Jan 4 14:53:37 2016  davet_:Joined the channel
Mon Jan 4 15:01:10 2016  zwoop:jpeach can you take a look at that ?
Mon Jan 4 15:01:49 2016  zwoop:felicity where do you see this specifically ?
Mon Jan 4 15:02:21 2016  zwoop:is the issue that we create a continuation, that never gets scheduled / released ?
Mon Jan 4 15:02:33 2016  felicity:zwoop: https://github.com/apache/trafficserver/pull/399/files#diff-e1bef8d5a034abc98e7b233959bceaa1R370
Mon Jan 4 15:02:38 2016  zwoop:(the cont takes ownership of the mutex btw)
Mon Jan 4 15:02:47 2016  felicity:zwoop: it creates the mutex at the start of the function, but not all codepaths create the continuation
Mon Jan 4 15:02:53 2016  felicity:if the continuation isn't created, the mutex is never freed
Mon Jan 4 15:02:59 2016  zwoop:I see
Mon Jan 4 15:03:11 2016  zwoop:Hmmm
Mon Jan 4 15:03:21 2016  zwoop:The original patch seems to have done
Mon Jan 4 15:03:22 2016  zwoop:- consume_cont = TSContCreate(consume_resource, NULL);
Mon Jan 4 15:03:22 2016  zwoop:+ consume_cont = TSContCreate(consume_resource, TSMutexCreate());
Mon Jan 4 15:03:26 2016  zwoop:what changed here
Mon Jan 4 15:05:01 2016  zwoop:felicity yeah, I don't think that was ever committed
Mon Jan 4 15:05:05 2016  zwoop:the code that's committed is
Mon Jan 4 15:05:05 2016  felicity:ah
Mon Jan 4 15:05:06 2016  zwoop: consume_cont = TSContCreate(consume_resource, TSMutexCreate());
Mon Jan 4 15:05:11 2016  felicity:yes, i see: https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;a=commitdiff;h=e52f060;hp=a8b4a90af38645079879d5d20a678e5035137802
Mon Jan 4 15:05:37 2016  felicity:so it was fixed without merging the PR, okay :)
Mon Jan 4 15:06:26 2016  zwoop:I think it merged another PR ?
Mon Jan 4 15:06:27 2016  zwoop:looking
Mon Jan 4 15:06:39 2016  zwoop:Either that, or jpeach fixed the commit before pushing
Mon Jan 4 15:07:00 2016  zwoop:He probably should have said so in the commit message :)
Mon Jan 4 15:08:38 2016  es:Joined the channel
Mon Jan 4 15:36:00 2016  biilmann:Joined the channel
Mon Jan 4 15:56:26 2016  yamc:Joined the channel
Mon Jan 4 16:00:32 2016  jumby:Joined the channel
Mon Jan 4 16:13:53 2016  reveller:Joined the channel
Mon Jan 4 16:19:23 2016  yamc:Joined the channel
Mon Jan 4 16:19:40 2016  shinrich1:Joined the channel
Mon Jan 4 16:21:56 2016  shinrich2:Joined the channel
Mon Jan 4 16:30:37 2016  psp:Joined the channel
Mon Jan 4 16:32:43 2016  biilmann:Joined the channel
Mon Jan 4 16:44:08 2016  reveller1:Joined the channel
Mon Jan 4 16:44:39 2016  sudheerv:Happy New Year, everyone!
Mon Jan 4 16:47:20 2016  bcall:sudheerv: hey, have a good vacation?
Mon Jan 4 16:48:54 2016  sudheerv:bcall: yeah, :), you?
Mon Jan 4 16:49:31 2016  sudheerv:december was unusual at y! this time :)
Mon Jan 4 16:49:32 2016  bcall:yeah, it was nice to have a vacation and very little email when coming back
Mon Jan 4 16:49:42 2016  sudheerv:yeah, exactly :)
Mon Jan 4 16:52:09 2016  zwoop:bcall just delete the Inbox, done!
Mon Jan 4 16:52:30 2016  sudheerv:haha
Mon Jan 4 16:52:53 2016  sudheerv:i wish that's how easy it is - unfortunately, people are smart to send reminders ;)
Mon Jan 4 16:53:01 2016  bcall:I only have about 20 work email to read, none that important anyways
Mon Jan 4 16:53:30 2016  sudheerv:yeah, it was a bit too active before the holidays this time and completely silent during the holidays :)
Mon Jan 4 16:57:33 2016  yamc:Joined the channel
Mon Jan 4 16:57:49 2016  blattj:Joined the channel
Mon Jan 4 17:00:08 2016  blattj:Joined the channel
Mon Jan 4 17:02:43 2016  igalic:hey, did you know that https://github.com/jfbastien/papers/blob/master/source/N4455.rst
Mon Jan 4 17:27:32 2016  jrushford:Joined the channel
Mon Jan 4 17:52:13 2016  gancho_:Joined the channel
Mon Jan 4 18:22:51 2016  blattj:Joined the channel
Mon Jan 4 18:38:18 2016  yamc:Joined the channel
Mon Jan 4 19:09:08 2016  shinrich1:Joined the channel
Mon Jan 4 19:09:29 2016  zwoop:nice
Mon Jan 4 19:27:31 2016  shinrich1:Joined the channel
Mon Jan 4 19:41:32 2016  jacksontj:Joined the channel
Mon Jan 4 19:59:43 2016  bahumbug:Joined the channel
Mon Jan 4 20:36:34 2016  shinrich1:Joined the channel
Mon Jan 4 20:45:39 2016  biilmann:Joined the channel
Mon Jan 4 22:57:58 2016  shinrich1:Joined the channel
Mon Jan 4 22:59:44 2016  shinrich2:Joined the channel
Mon Jan 4 23:04:20 2016  jrushford:Joined the channel
Mon Jan 4 23:15:49 2016  bahumbug:Joined the channel

Comments